public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Romain Perier <romain.perier@collabora.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 4/4] arm: dts: rockchip: Enable post_ios_power_on and pre-power-on-delay-ms
Date: Wed, 01 Mar 2017 23:43:30 +0100	[thread overview]
Message-ID: <2352931.6xxz4r33MQ@phil> (raw)
In-Reply-To: <20170301145310.22813-5-romain.perier@collabora.com>

Hi Romain,

Am Mittwoch, 1. März 2017, 15:53:10 CET schrieb Romain Perier:
> This enables the property post_ios_power_on. With this property, the
> driver pwrseq_simple will do its entire power sequence at the end of the
> mmc_power_up() function. The property pre-power-on-delay-ms adds a delay
> of 1ms between the enablement of the clk and the assertion of the reset
> line.
> 
> It fixes the power-up sequence for the Wifi chipset AP6335.
> 
> Signed-off-by: Romain Perier <romain.perier@collabora.com>

I didn't get the other 3 patches touching the mmc subsystem, so if and when 
they get accepted, please ping this devicetree patch.


> ---
>  arch/arm/boot/dts/rk3288-rock2-square.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-rock2-square.dts
> b/arch/arm/boot/dts/rk3288-rock2-square.dts index 818c4bf..9bf2991 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-square.dts
> +++ b/arch/arm/boot/dts/rk3288-rock2-square.dts
> @@ -106,6 +106,8 @@
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&wifi_enable>;
>  		reset-gpios = <&gpio4 28 GPIO_ACTIVE_LOW>;
> +		pre-power-on-delay-ms = <1>;
> +		post-ios-power-on;

If you need to resend your series, please make sure you have alphabetically 
sorted properties -> pinctrl, post-ios-..., pre-power-... and finally reset-
gpios. No need to resend just for this though, as I can reorder them myself if 
needed.


Thanks
Heiko

      reply	other threads:[~2017-03-01 23:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01 14:53 [PATCH 0/4] mmc: pwrseq: post_ios power sequence Romain Perier
2017-03-01 14:53 ` [PATCH 1/4] mmc: core: Add post_ios_power_on callback for power sequences Romain Perier
2017-03-16 12:55   ` Ulf Hansson
2017-03-01 14:53 ` [PATCH 2/4] mmc: pwrseq-simple: Add optional op. for post_ios_power_on callback Romain Perier
2017-03-01 14:53 ` [PATCH 3/4] mmc: pwrseq_simple: Add an optional pre-power-on-delay Romain Perier
2017-03-01 14:53 ` [PATCH 4/4] arm: dts: rockchip: Enable post_ios_power_on and pre-power-on-delay-ms Romain Perier
2017-03-01 22:43   ` Heiko Stuebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2352931.6xxz4r33MQ@phil \
    --to=heiko@sntech.de \
    --cc=linux-mmc@vger.kernel.org \
    --cc=romain.perier@collabora.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox