Re: [PATCH 2/2] mmc: mxcmmc: Convert to SIMPLE_DEV_PM_OPS

Alexander Shiyan
2014-02-22T15:02:51Z

Суббота, 22 февраля 2014, 11:59 -03:00 от Fabio Estevam <festevam@gmail.com>:
> On Sat, Feb 22, 2014 at 11:57 AM, Alexander Shiyan <shc_work@mail.ru> wrote:
> > Суббота, 22 февраля 2014, 11:51 -03:00 от Fabio Estevam <festevam@gmail.com>:
> >> On Sat, Feb 22, 2014 at 11:46 AM, Alexander Shiyan <shc_work@mail.ru> wrote:
> >> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> >> > ---
> >> > drivers/mmc/host/mxcmmc.c | 13 +++----------
> >> > 1 file changed, 3 insertions(+), 10 deletions(-)
> >> >
> >> > diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c
> >> > index 84d630e..86401c0 100644
> >> > --- a/drivers/mmc/host/mxcmmc.c
> >> > +++ b/drivers/mmc/host/mxcmmc.c
> >> > @@ -1220,8 +1220,7 @@ static int mxcmci_remove(struct platform_device *pdev)
> >> > return 0;
> >> > }
> >> >
> >> > -#ifdef CONFIG_PM
> >> > -static int mxcmci_suspend(struct device *dev)
> >>
> >> Doesn't this need to be protected by CONFIG_PM_SLEEP?
> >
> > No, this already protected by SIMPLE_DEV_PM_OPS(),
> > see include/linux/pm.h.
>
> but then you would get a warning saying that "mxcmci_suspend/resume"
> are defined by not used" when CONFIG_PM_SLEEP=n

Please see the patch first,
this warnings is avoided by "__maybe_unused" attributes.

---