From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Chunyan Zhang <zhang.chunyan@linaro.org>,
Baolin Wang <baolin.wang@linaro.org>,
linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH] RFC: mmc: block: replace semaphore with freezing
Date: Wed, 16 Nov 2016 13:19:40 +0100 [thread overview]
Message-ID: <2389754.pTXLssq8q3@wuerfel> (raw)
In-Reply-To: <1479293464-4576-1-git-send-email-linus.walleij@linaro.org>
On Wednesday, November 16, 2016 11:51:04 AM CET Linus Walleij wrote:
> @@ -95,12 +95,9 @@ static int mmc_queue_thread(void *d)
> set_current_state(TASK_RUNNING);
> break;
> }
> - up(&mq->thread_sem);
> - schedule();
> - down(&mq->thread_sem);
> + try_to_freeze();
>
The schedule() here is where we wait for new requests to come in
from mmc_request_fn(), you can't remove that or you end up spinning
continuously.
Arnd
next prev parent reply other threads:[~2016-11-16 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 10:51 [PATCH] RFC: mmc: block: replace semaphore with freezing Linus Walleij
2016-11-16 12:19 ` Arnd Bergmann [this message]
2016-11-16 12:46 ` Rafael J. Wysocki
2016-11-16 12:57 ` Jiri Kosina
2016-11-16 15:20 ` Linus Walleij
2016-11-16 16:32 ` Arnd Bergmann
2016-11-22 8:54 ` Linus Walleij
2016-11-22 9:10 ` Russell King - ARM Linux
2016-11-22 9:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2389754.pTXLssq8q3@wuerfel \
--to=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox