public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] mmc: quirks: Fixup debug message
@ 2014-05-20 11:29 Alexander Stein
  2014-06-03  7:54 ` Alexander Stein
  2014-06-16  8:55 ` Ulf Hansson
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2014-05-20 11:29 UTC (permalink / raw)
  To: Ulf Hansson, Chris Ball; +Cc: Alexander Stein, linux-mmc

There is no need for an output like this:
> mmcblk mmc1:0001: calling add_quirk_mmc+0x0/0x20
Instead use this one:
> mmcblk mmc1:0001: calling add_quirk_mmc

Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
 drivers/mmc/core/quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/quirks.c b/drivers/mmc/core/quirks.c
index 6c36fcc..dd1d1e0 100644
--- a/drivers/mmc/core/quirks.c
+++ b/drivers/mmc/core/quirks.c
@@ -91,7 +91,7 @@ void mmc_fixup_device(struct mmc_card *card, const struct mmc_fixup *table)
 		    (f->cis_device == card->cis.device ||
 		     f->cis_device == (u16) SDIO_ANY_ID) &&
 		    rev >= f->rev_start && rev <= f->rev_end) {
-			dev_dbg(&card->dev, "calling %pF\n", f->vendor_fixup);
+			dev_dbg(&card->dev, "calling %pf\n", f->vendor_fixup);
 			f->vendor_fixup(card, f->data);
 		}
 	}
-- 
1.8.5.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] mmc: quirks: Fixup debug message
  2014-05-20 11:29 [PATCH 1/1] mmc: quirks: Fixup debug message Alexander Stein
@ 2014-06-03  7:54 ` Alexander Stein
  2014-06-16  8:55 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2014-06-03  7:54 UTC (permalink / raw)
  To: Ulf Hansson; +Cc: Chris Ball, linux-mmc

Any feedback in this?

Thanks,
Alexander

On Tuesday 20 May 2014 13:29:21, Alexander Stein wrote:
> There is no need for an output like this:
> > mmcblk mmc1:0001: calling add_quirk_mmc+0x0/0x20
> Instead use this one:
> > mmcblk mmc1:0001: calling add_quirk_mmc
> 
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>  drivers/mmc/core/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/core/quirks.c b/drivers/mmc/core/quirks.c
> index 6c36fcc..dd1d1e0 100644
> --- a/drivers/mmc/core/quirks.c
> +++ b/drivers/mmc/core/quirks.c
> @@ -91,7 +91,7 @@ void mmc_fixup_device(struct mmc_card *card, const struct mmc_fixup *table)
>  		    (f->cis_device == card->cis.device ||
>  		     f->cis_device == (u16) SDIO_ANY_ID) &&
>  		    rev >= f->rev_start && rev <= f->rev_end) {
> -			dev_dbg(&card->dev, "calling %pF\n", f->vendor_fixup);
> +			dev_dbg(&card->dev, "calling %pf\n", f->vendor_fixup);
>  			f->vendor_fixup(card, f->data);
>  		}
>  	}
> 

-- 
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein@systec-electronic.com
Website: www.systec-electronic.com
 
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] mmc: quirks: Fixup debug message
  2014-05-20 11:29 [PATCH 1/1] mmc: quirks: Fixup debug message Alexander Stein
  2014-06-03  7:54 ` Alexander Stein
@ 2014-06-16  8:55 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2014-06-16  8:55 UTC (permalink / raw)
  To: Alexander Stein; +Cc: Chris Ball, linux-mmc

On 20 May 2014 13:29, Alexander Stein
<alexander.stein@systec-electronic.com> wrote:
> There is no need for an output like this:
>> mmcblk mmc1:0001: calling add_quirk_mmc+0x0/0x20
> Instead use this one:
>> mmcblk mmc1:0001: calling add_quirk_mmc
>
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>

Thanks! Applied for next.

Kind regards
Uffe

> ---
>  drivers/mmc/core/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/quirks.c b/drivers/mmc/core/quirks.c
> index 6c36fcc..dd1d1e0 100644
> --- a/drivers/mmc/core/quirks.c
> +++ b/drivers/mmc/core/quirks.c
> @@ -91,7 +91,7 @@ void mmc_fixup_device(struct mmc_card *card, const struct mmc_fixup *table)
>                     (f->cis_device == card->cis.device ||
>                      f->cis_device == (u16) SDIO_ANY_ID) &&
>                     rev >= f->rev_start && rev <= f->rev_end) {
> -                       dev_dbg(&card->dev, "calling %pF\n", f->vendor_fixup);
> +                       dev_dbg(&card->dev, "calling %pf\n", f->vendor_fixup);
>                         f->vendor_fixup(card, f->data);
>                 }
>         }
> --
> 1.8.5.5
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-06-16  8:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-20 11:29 [PATCH 1/1] mmc: quirks: Fixup debug message Alexander Stein
2014-06-03  7:54 ` Alexander Stein
2014-06-16  8:55 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox