From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. Date: Wed, 06 May 2015 10:40:03 +0200 Message-ID: <2568634.iEosTvMJpM@wuerfel> References: <1430817426-5241-1-git-send-email-stripathi@apm.com> <4635229.bceBxngCoe@wuerfel> <5549C68B.9090602@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([212.227.126.131]:57037 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbbEFIkS (ORCPT ); Wed, 6 May 2015 04:40:18 -0400 In-Reply-To: <5549C68B.9090602@xilinx.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Michal Simek Cc: Suman Tripathi , Rob Herring , "chris@printf.net" , Anton Vorontsov , "linux-mmc@vger.kernel.org" , linuxppc-dev , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Don Dutile , "jcm@redhat.com" , Mark Langsdorf , "patches@apm.com" On Wednesday 06 May 2015 09:45:15 Michal Simek wrote: > On 05/06/2015 09:31 AM, Arnd Bergmann wrote: > > On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote: > >>>> @@ -533,6 +567,16 @@ > >>>> interrupts = <0x0 0x4f 0x4>; > >>>> }; > >>>> > >>>> + sdhc0: sdhc@1c000000 { > >>>> + device_type = "sdhc"; > >>> > >>> device_type generally should not be used (there are a few exceptions). > >> > >> Okay !! > >> > > > > While we're at it, please change sdhc@1c000000 to mmc@1c000000. > > Even though Linux does not care, we try to use the standard device > > names for consistency. > > Do we have a list of these names somewhere? > Normally I do use ePARP - generic names recommendation but mmc or sdhci > are not listed there. > Both combination mmc@ or sdhci@ are used in the kernel. > > On zynq and zynqmp we do use shdci@. > Ah, I thought ePAPR listed mmc already. Using "sdhci" is a little too specific here, since a lot of mmc hosts are not sdhci compliant, and "sdhc" is completely wrong, because that identifies a specific card type, but a host that supports SDHC cards will generally also work with SD (less than 4GB) or SDXC (more than 48GB) cards. Arnd