From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] mmc: sh_mmcif: Support MMC_SLEEP_AWAKE command Date: Wed, 20 Jun 2012 15:06:36 +0200 Message-ID: <2609967.tcqa2xCl8R@avalon> References: <1339534569-27923-1-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:43515 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753814Ab2FTNGZ (ORCPT ); Wed, 20 Jun 2012 09:06:25 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: linux-mmc@vger.kernel.org, Guennadi Liakhovetski , Simon Horman , linux-sh@vger.kernel.org, Saugata Das , Girish Shivananjappa Hi Ulf, On Wednesday 20 June 2012 13:54:33 Ulf Hansson wrote: > Hi Laurent, > > Your issue seem more related to a mmc protocol problem. Likely caused > by a bad patch for eMMC 4.5 poweroff notify. The patch I refer to is: > "mmc: core: Fix PowerOff Notify suspend/resume" > > You may try to revert this patch and see if the same problem occurs for you. > > We are trying to fix the issue inserted by the above commit in a patch > named: "MMC-4.5 Power OFF Notify Rework", please have a look if you have > the time. I think the two issues are othorgonal (but please feel free to tell me if there's something I'm missing). The MMCIF controller driver rejects the MMC_SLEEP_AWAKE command unconditionally, even though it should be accepted, because it happens to share the command number with an SDIO command (SD_IO_SEND_OP_COND) used to probe SDIO support. My patch fixes this by accepting the MMC_SLEEP_AWAKE command but still rejecting the SD_IO_SEND_OP_COND command. -- Regards, Laurent Pinchart