From: Krzysztof Kozlowski <krzk@kernel.org>
To: Detlev Casanova <detlev.casanova@collabora.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jisheng Zhang <jszhang@kernel.org>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 1/1] dt-bindings: mmc: Add support for rk3576 eMMC
Date: Wed, 4 Sep 2024 16:25:54 +0200 [thread overview]
Message-ID: <26d8ecbe-0d85-4be2-a142-861088e43918@kernel.org> (raw)
In-Reply-To: <1896150.tdWV9SEqCh@trenzalore>
On 04/09/2024 16:20, Detlev Casanova wrote:
>>>>> + properties:
>>>>> + power-domains:
>>>>> + minItems: 1
>>>>
>>>> Why minItems? This does not look right. I don't get what you are trying
>>>> to say here.
>>>
>>> I'm saying that for the rockchip,rk3576-dwcmshc compatible, 1 power-domain
>>> node has to be set.
>>
>> The top-level property already says this. You need to disallow it for
>> other variants (:false).
>
> Ok, something like this:
>
> allOf:
> - if:
> properties:
> compatible:
> contains:
> const: rockchip,rk3576-dwcmshc
>
> then:
> required:
> - power-domains
>
> else:
> properties:
> power-domains: false
Yes, if they are required. Otherwise use "if: not:" and just disallow them.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-09-04 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 14:51 [PATCH 0/1] dt-bindings: mmc: Add support for rk3576 eMMC Detlev Casanova
2024-09-03 14:51 ` [PATCH 1/1] " Detlev Casanova
2024-09-04 6:00 ` Krzysztof Kozlowski
2024-09-04 12:56 ` Detlev Casanova
2024-09-04 13:02 ` Krzysztof Kozlowski
2024-09-04 14:20 ` Detlev Casanova
2024-09-04 14:25 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26d8ecbe-0d85-4be2-a142-861088e43918@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox