From: Arnd Bergmann <arnd@arndb.de>
To: Suman Tripathi <stripathi@apm.com>
Cc: devicetree@vger.kernel.org, mlangsdo@redhat.com, jcm@redhat.com,
anton@enomsg.org, linux-mmc@vger.kernel.org, chris@printf.net,
patches@apm.com, ddutile@redhat.com,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] mmc: host: arasan: Add addition of-arasan quirks and IOMMU support for arasan SDHCI driver.
Date: Tue, 27 Jan 2015 21:12:39 +0100 [thread overview]
Message-ID: <2889598.XIWjCcRL7e@wuerfel> (raw)
In-Reply-To: <1422379260-10139-2-git-send-email-stripathi@apm.com>
On Tuesday 27 January 2015 22:50:59 Suman Tripathi wrote:
> @@ -174,6 +176,13 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
> pltfm_host->priv = sdhci_arasan;
> pltfm_host->clk = clk_xin;
>
> + ret = xgene_ahbc_iommu_attach_device(&pdev->dev);
> + if (ret < 0 && IS_ENABLED(CONFIG_XGENE_AHBC_IOMMU)) {
> + dev_err(&pdev->dev,
> + "unable to attach device to iommu %x\n", ret);
> + goto clk_disable_all;
> + }
> +
> ret = sdhci_add_host(host);
> if (ret) {
> dev_err(&pdev->dev, "platform register failed (%u)\n", ret);
>
This looks wrong: the iommu should be automatically configured for devices
that need it, without any interaction from the driver.
Arnd
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2015-01-27 20:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 17:20 [PATCH v1 0/2] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller Suman Tripathi
2015-01-27 17:20 ` [PATCH v1 1/2] mmc: host: arasan: Add addition of-arasan quirks and IOMMU support for arasan SDHCI driver Suman Tripathi
2015-01-27 20:12 ` Arnd Bergmann [this message]
2015-01-27 17:21 ` [PATCH v1 2/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi Suman Tripathi
2015-01-27 20:13 ` Arnd Bergmann
2015-01-28 4:18 ` Suman Tripathi
2015-01-28 4:23 ` Suman Tripathi
2015-01-28 12:46 ` Arnd Bergmann
2015-01-28 13:22 ` Suman Tripathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2889598.XIWjCcRL7e@wuerfel \
--to=arnd@arndb.de \
--cc=anton@enomsg.org \
--cc=chris@printf.net \
--cc=ddutile@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mlangsdo@redhat.com \
--cc=patches@apm.com \
--cc=stripathi@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox