Re: [PATCH v3 01/15] phy: rockchip-emmc: give DLL some extra time to be ready

Doug Anderson
2016-06-20T19:38:37Z

Hi,

On Mon, Jun 20, 2016 at 12:36 PM, Guenter Roeck <groeck-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
> On Mon, Jun 20, 2016 at 12:30 PM, Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
>> Hi,
>>
>> On Mon, Jun 20, 2016 at 12:23 PM, Guenter Roeck <groeck-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
>>> On Mon, Jun 20, 2016 at 10:56 AM, Douglas Anderson
>>> <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
>>>> From: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>>>>
>>>> According to the databook, 10.2us is the max time for dll to be ready to
>>>> work. However in testing, some chips need 20us for dll to be ready. This
>>>
>>> Nitpick, but description (20uS) and code (more than 25 uS) don't match.
>>
>> Good catch. If I spin the series I'll fix this, otherwise I'll assume
>> that the person applying this (Ulf?) can fix the description at their
>> discretion.
>>
>
> Not that it matters much, as the code is replaced in a later patch
> anyway. It might make more sense to merge the two patches into one.

Yes. At the time I wrote it it was unclear what the status of the
original patch was (whether it would be applied sooner vs. later). At
this point it seemed expedient to continue to keep the patches
separate since they had been reviewed and tested separately. Earlier
I made the offer to combine and re-spin and I'm happy to do that if
requested.

-Doug