From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-mmc-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 45D5AEB64D7
	for <linux-mmc@archiver.kernel.org>; Wed, 21 Jun 2023 02:36:43 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229482AbjFUCgl (ORCPT <rfc822;linux-mmc@archiver.kernel.org>);
        Tue, 20 Jun 2023 22:36:41 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48582 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229522AbjFUCgl (ORCPT
        <rfc822;linux-mmc@vger.kernel.org>); Tue, 20 Jun 2023 22:36:41 -0400
Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6656B19B0
        for <linux-mmc@vger.kernel.org>; Tue, 20 Jun 2023 19:36:22 -0700 (PDT)
Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28])
        (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))
        (No client certificate requested)
        (Authenticated sender: marex@denx.de)
        by phobos.denx.de (Postfix) with ESMTPSA id C62AC861FE;
        Wed, 21 Jun 2023 04:36:17 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de;
        s=phobos-20191101; t=1687314979;
        bh=C5NFC6aSaVhYRl0Y3x0IlJZKfbgEhMrpbLAVPYjBu94=;
        h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
        b=qdg7FRtns2zl9CirDHCROBBs/4JvuMatKjeHM52/t1/dl8AOpO0CPehwBa6TuNnj+
         IM1T8Ctw+76j+i5TKi+mFuOXPDfOzbcpzLVFy+Gb+zMrltn3fMOikpUMYQP0RQ4DZN
         XI71Id01fESQHh/knJuw+gJtsmIKGJmdwTC9Kzvr6ay2PoryXgDHxkUoPVpBGA1IoQ
         /zREwrTzBHM8kIpKCu5FKloTM6RlDlQRODHfBNx6iBQ3feFQ6pJmTX8H10DHvmjhaW
         Jt100lhy66WdcqniylkG62PoK7R9mex1Ue5EvRE5lC5muGVxvDdeGBnNu3qFqnCJ1y
         gAdehOPgayIyA==
Message-ID: <289cd876-e6e1-8610-bcb6-b0259c68fd89@denx.de>
Date:   Wed, 21 Jun 2023 04:36:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 01/11] mmc: core: Use BIT() macro
Content-Language: en-US
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     linux-mmc@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>,
        Avri Altman <avri.altman@wdc.com>, Bo Liu <liubo03@inspur.com>,
        Deren Wu <deren.wu@mediatek.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Pierre Ossman <pierre@ossman.eu>,
        Russell King <linux@armlinux.org.uk>,
        Yang Yingliang <yangyingliang@huawei.com>
References: <20230620104722.16465-1-marex@denx.de>
 <CAPDyKFqZ_r=gjpRm833ax4LwASCTGAuO0a0ABXo-kN8dtYje-Q@mail.gmail.com>
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <CAPDyKFqZ_r=gjpRm833ax4LwASCTGAuO0a0ABXo-kN8dtYje-Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de
X-Virus-Status: Clean
Precedence: bulk
List-ID: <linux-mmc.vger.kernel.org>
X-Mailing-List: linux-mmc@vger.kernel.org

On 6/20/23 13:15, Ulf Hansson wrote:
> On Tue, 20 Jun 2023 at 12:47, Marek Vasut <marex@denx.de> wrote:
>>
>> Use the BIT(n) macro instead of (1<<n), no functional change.
>> Regex 's@(1 \?<< \?\([0-9A-Z_]\+\))@BIT(\1)' .
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
> 
> I don't think the benefit of this change is worth it. For example,
> it's quite useful to run a git blame to see the history of what has
> happened.

Understood.

git blame does allow you to specify either --since or revision range though.

> So, sorry, but I am not going to pick this up - or any other similar
> changes, at least for the core layer.

Is this a policy of the mmc subsystem to reject all code clean ups then ?