From: Arnd Bergmann <arnd@arndb.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Icenowy Zheng <icenowy@aosc.xyz>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] dt: bindings: Add binding for ESP8089 wifi chips
Date: Sun, 07 Aug 2016 21:59:13 +0200 [thread overview]
Message-ID: <2936779.FAiO1bqUWV@wuerfel> (raw)
In-Reply-To: <1470596269-20572-2-git-send-email-hdegoede@redhat.com>
On Sunday, August 7, 2016 8:57:49 PM CEST Hans de Goede wrote:
> +Espressif ESP8089 wireless SDIO devices
> +
> +This node provides properties for controlling the ESP8089 wireless device.
> +The node is expected to be specified as a child node to the SDIO controller
> +that connects the device to the system.
> +
> +Required properties:
> +
> + - compatible : Should be "esp,esp8089".
I think it would be good to standardize a compatible string for sdio
like we have it for other discoverable buses, based on the
vendor/device ID (or whatever this uses), using something like
compatible = "sdio1234,5678", "esp,esp8089";
> +Optional properties:
> + - esp,crystal_26M_en: Integer value for the crystal_26M_en firmware parameter
better use '-' instead of '_' for property names.
Arnd
next prev parent reply other threads:[~2016-08-07 19:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 18:57 [PATCH 1/2] dt: bindings: Add vendor prefix for Espressif System Hans de Goede
2016-08-07 18:57 ` [PATCH 2/2] dt: bindings: Add binding for ESP8089 wifi chips Hans de Goede
2016-08-07 19:59 ` Arnd Bergmann [this message]
2016-08-08 3:59 ` Chen-Yu Tsai
[not found] ` <CAGb2v67+QrOxPd4KeLb9F67A0mSaBqn14PynzCyK=ovRnKA6EQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-08 9:24 ` Arnd Bergmann
2016-08-08 12:44 ` Icenowy Zheng
2016-08-08 2:36 ` Icenowy Zheng
2016-08-08 7:34 ` Hans de Goede
2016-08-08 12:42 ` Icenowy Zheng
2016-08-10 18:48 ` [PATCH 1/2] dt: bindings: Add vendor prefix for Espressif System Rob Herring
2016-08-11 9:15 ` Hans de Goede
2016-08-11 13:31 ` Rob Herring
2016-08-11 15:08 ` Hans de Goede
2016-08-11 16:35 ` Rob Herring
2016-08-11 17:13 ` Hans de Goede
2016-08-11 17:28 ` Hans de Goede
2016-08-11 18:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2936779.FAiO1bqUWV@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox