From mboxrd@z Thu Jan 1 00:00:00 1970 From: merez@codeaurora.org Subject: Re: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device Date: Sun, 13 Nov 2011 05:04:26 -0800 (PST) Message-ID: <29dbe1d4d0e92bc4b4acf1ac2909f2df.squirrel@www.codeaurora.org> References: <620ec9ffa6bdbba9ae5f76998e36f8dc.squirrel@www.codeaurora.org> <001001cca043$395dbfc0$ac193f40$%jun@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:26267 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963Ab1KMNE1 (ORCPT ); Sun, 13 Nov 2011 08:04:27 -0500 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Seungwon Jeon Cc: "S, Venkatraman" , merez@codeaurora.org, linux-mmc@vger.kernel.org, Chris Ball , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, dh.han@samsung.com >> On Fri, Nov 11, 2011 at 12:56 PM, Seungwon Jeon >> wrote: >>> Maya Erez wrote: >>>> On Thu, Nov 10, 2011 Maya Erez wrote: >>>> > S, Venkatraman wrote: >>>> >> On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon >>>> >>>> wrote: >>>> >> >> > +static u8 mmc_blk_chk_packable(struct mmc_queue *mq, struct >>>> >> request *req) >>>> >>>> The function prepares the checkable list and not only checks if >>>> packing >>>> is >>>> possible, therefore I think its name should change to reflect its real >>>> action >>> I labored at naming. Isn't it proper? :) >>> Do you have any recommendation? >>> group_pack_req? >>> How about mmc_blk_prep_packed_list? Thanks, Maya Erez Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum