* [PATCH v3 0/2] Enable Inline crypto engine for kodiak @ 2026-02-06 11:20 Neeraj Soni 2026-02-06 11:20 ` [PATCH v3 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle Neeraj Soni 2026-02-06 11:20 ` [PATCH v3 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC Neeraj Soni 0 siblings, 2 replies; 6+ messages in thread From: Neeraj Soni @ 2026-02-06 11:20 UTC (permalink / raw) To: ulf.hansson, robh, krzk+dt, conor+dt, andersson, konradybcio Cc: linux-mmc, devicetree, linux-kernel, neeraj.soni Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree node to enable it for kodiak. How this patch was tested: - export ARCH=arm64 - export CROSS_COMPILE=aarch64-linux-gnu- - make menuconfig - make defconifg - make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check - make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y dtbs --- Changes in v3: - Described the purpose for phandle in "description:" for "qcom,ice". - Re-added the "if: required:" description for "qcom,ice" with proper encoding. - Corrected the uppercase for base address and reg address space for ICE DT node. Changes in v2: - Removed the "if: required:" description for "qcom,ice" dt-binding as the ICE node is optional. - Corrected the ICE dt node entry according to the dt-binding description. - Added test details. Changes in v1: - Updated the dt-binding for ICE node. - Added the dt node for ICE for kodiak. Neeraj Soni (2): dt-bindings: mmc: sdhci-msm: Add ICE phandle arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC .../devicetree/bindings/mmc/sdhci-msm.yaml | 26 +++++++++++++++++++ arch/arm64/boot/dts/qcom/kodiak.dtsi | 9 +++++++ 2 files changed, 35 insertions(+) -- 2.34.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle 2026-02-06 11:20 [PATCH v3 0/2] Enable Inline crypto engine for kodiak Neeraj Soni @ 2026-02-06 11:20 ` Neeraj Soni 2026-02-06 11:26 ` Krzysztof Kozlowski 2026-02-06 11:20 ` [PATCH v3 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC Neeraj Soni 1 sibling, 1 reply; 6+ messages in thread From: Neeraj Soni @ 2026-02-06 11:20 UTC (permalink / raw) To: ulf.hansson, robh, krzk+dt, conor+dt, andersson, konradybcio Cc: linux-mmc, devicetree, linux-kernel, neeraj.soni, Abel Vesa, Abhinaba Rakshit Starting with sc7280(kodiak), the ICE will have its own device-tree node. So add the qcom,ice property to reference it. Co-developed-by: Abel Vesa <abel.vesa@linaro.org> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> Co-developed-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com> --- Some initial work is done by Abel here: https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/ and by Abhinaba here: https://lore.kernel.org/all/20251009-add-separate-ice-ufs-and-emmc-device-nodes-for-qcs615-platform-v1-1-2a34d8d03c72@oss.qualcomm.com/ This patch adds the purpose and usage for phandle in the description and encodes it properly in the schema. --- .../devicetree/bindings/mmc/sdhci-msm.yaml | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml index 938be8228d66..f35b675c9f16 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml @@ -140,6 +140,12 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 description: platform specific settings for DLL_CONFIG reg. + qcom,ice: + $ref: /schemas/types.yaml#/definitions/phandle + description: | + phandle to the Inline Crypto Engine node. ICE having its own platform driver will use this phandle to + manage its resources independently. Either add this phandle or ICE address space for ICE to work. + iommus: minItems: 1 maxItems: 8 @@ -223,6 +229,26 @@ allOf: - const: cqhci - const: ice + - if: + required: + - qcom,ice + then: + properties: + reg: + minItems: 1 + maxItems: 3 + reg-names: + minItems: 1 + maxItems: 3 + else: + properties: + reg: + minItems: 1 + maxItems: 4 + reg-names: + minItems: 1 + maxItems: 4 + unevaluatedProperties: false examples: -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle 2026-02-06 11:20 ` [PATCH v3 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle Neeraj Soni @ 2026-02-06 11:26 ` Krzysztof Kozlowski 2026-02-16 11:05 ` Neeraj Soni 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2026-02-06 11:26 UTC (permalink / raw) To: Neeraj Soni, ulf.hansson, robh, krzk+dt, conor+dt, andersson, konradybcio Cc: linux-mmc, devicetree, linux-kernel, Abel Vesa, Abhinaba Rakshit On 06/02/2026 12:20, Neeraj Soni wrote: > Starting with sc7280(kodiak), the ICE will have its own device-tree node. > So add the qcom,ice property to reference it. > > Co-developed-by: Abel Vesa <abel.vesa@linaro.org> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > Co-developed-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> > Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> > Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com> > > --- > > Some initial work is done by Abel here: > https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/ > and by Abhinaba here: > https://lore.kernel.org/all/20251009-add-separate-ice-ufs-and-emmc-device-nodes-for-qcs615-platform-v1-1-2a34d8d03c72@oss.qualcomm.com/ > > This patch adds the purpose and usage for phandle in the description and encodes > it properly in the schema. > --- > .../devicetree/bindings/mmc/sdhci-msm.yaml | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > index 938be8228d66..f35b675c9f16 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > @@ -140,6 +140,12 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > description: platform specific settings for DLL_CONFIG reg. > > + qcom,ice: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | > + phandle to the Inline Crypto Engine node. ICE having its own platform driver will use this phandle to Please wrap code according to the preferred limit expressed in Kernel coding style (checkpatch is not a coding style description, but only a tool). However don't wrap blindly (see Kernel coding style). Do not need '|' unless you need to preserve formatting. I do not understand the platform driver reference here. You are supposed to explain how the hardware uses it, for what purpose. If I change Linux to use auxilary driver, then the binding is incorrect? > + manage its resources independently. Either add this phandle or ICE address space for ICE to work. Don't repeat constraints in free form text. Such trivialities should not happen, I am sometimes skipping deep dive review, so I skipped the rest. : Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle 2026-02-06 11:26 ` Krzysztof Kozlowski @ 2026-02-16 11:05 ` Neeraj Soni 2026-02-16 11:08 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Neeraj Soni @ 2026-02-16 11:05 UTC (permalink / raw) To: Krzysztof Kozlowski, ulf.hansson, robh, krzk+dt, conor+dt, andersson, konradybcio Cc: linux-mmc, devicetree, linux-kernel, Abel Vesa, Abhinaba Rakshit On 2/6/2026 4:56 PM, Krzysztof Kozlowski wrote: > On 06/02/2026 12:20, Neeraj Soni wrote: >> Starting with sc7280(kodiak), the ICE will have its own device-tree node. >> So add the qcom,ice property to reference it. >> >> Co-developed-by: Abel Vesa <abel.vesa@linaro.org> >> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >> Co-developed-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> >> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> >> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com> >> >> --- >> >> Some initial work is done by Abel here: >> https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/ >> and by Abhinaba here: >> https://lore.kernel.org/all/20251009-add-separate-ice-ufs-and-emmc-device-nodes-for-qcs615-platform-v1-1-2a34d8d03c72@oss.qualcomm.com/ >> >> This patch adds the purpose and usage for phandle in the description and encodes >> it properly in the schema. >> --- >> .../devicetree/bindings/mmc/sdhci-msm.yaml | 26 +++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> index 938be8228d66..f35b675c9f16 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> @@ -140,6 +140,12 @@ properties: >> $ref: /schemas/types.yaml#/definitions/uint32 >> description: platform specific settings for DLL_CONFIG reg. >> >> + qcom,ice: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: | >> + phandle to the Inline Crypto Engine node. ICE having its own platform driver will use this phandle to > > Please wrap code according to the preferred limit expressed in Kernel > coding style (checkpatch is not a coding style description, but only a > tool). However don't wrap blindly (see Kernel coding style). > Sure. While executing dt_binding_check the tool reported max limit as 110 characters so i wrapped around it. I will consolidate the description to single line in next patch. > Do not need '|' unless you need to preserve formatting. > Ack. I will limit the description to single line. > > I do not understand the platform driver reference here. You are supposed > to explain how the hardware uses it, for what purpose. If I change Linux > to use auxilary driver, then the binding is incorrect? > > >> + manage its resources independently. Either add this phandle or ICE address space for ICE to work. > > Don't repeat constraints in free form text> Ack. Will fix in next patch. > Such trivialities should not happen, I am sometimes skipping deep dive > review, so I skipped the rest. > > : > > > Best regards, > Krzysztof > Best Regards, Neeraj ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle 2026-02-16 11:05 ` Neeraj Soni @ 2026-02-16 11:08 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2026-02-16 11:08 UTC (permalink / raw) To: Neeraj Soni, ulf.hansson, robh, krzk+dt, conor+dt, andersson, konradybcio Cc: linux-mmc, devicetree, linux-kernel, Abel Vesa, Abhinaba Rakshit On 16/02/2026 12:05, Neeraj Soni wrote: > > > On 2/6/2026 4:56 PM, Krzysztof Kozlowski wrote: >> On 06/02/2026 12:20, Neeraj Soni wrote: >>> Starting with sc7280(kodiak), the ICE will have its own device-tree node. >>> So add the qcom,ice property to reference it. >>> >>> Co-developed-by: Abel Vesa <abel.vesa@linaro.org> >>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >>> Co-developed-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> >>> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com> >>> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com> >>> >>> --- >>> >>> Some initial work is done by Abel here: >>> https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/ >>> and by Abhinaba here: >>> https://lore.kernel.org/all/20251009-add-separate-ice-ufs-and-emmc-device-nodes-for-qcs615-platform-v1-1-2a34d8d03c72@oss.qualcomm.com/ >>> >>> This patch adds the purpose and usage for phandle in the description and encodes >>> it properly in the schema. >>> --- >>> .../devicetree/bindings/mmc/sdhci-msm.yaml | 26 +++++++++++++++++++ >>> 1 file changed, 26 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> index 938be8228d66..f35b675c9f16 100644 >>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> @@ -140,6 +140,12 @@ properties: >>> $ref: /schemas/types.yaml#/definitions/uint32 >>> description: platform specific settings for DLL_CONFIG reg. >>> >>> + qcom,ice: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: | >>> + phandle to the Inline Crypto Engine node. ICE having its own platform driver will use this phandle to >> >> Please wrap code according to the preferred limit expressed in Kernel >> coding style (checkpatch is not a coding style description, but only a >> tool). However don't wrap blindly (see Kernel coding style). >> > Sure. While executing dt_binding_check the tool reported max limit as 110 characters so i wrapped > around it. I will consolidate the description to single line in next patch. Can you read Linux kernel coding style as I asked? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC 2026-02-06 11:20 [PATCH v3 0/2] Enable Inline crypto engine for kodiak Neeraj Soni 2026-02-06 11:20 ` [PATCH v3 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle Neeraj Soni @ 2026-02-06 11:20 ` Neeraj Soni 1 sibling, 0 replies; 6+ messages in thread From: Neeraj Soni @ 2026-02-06 11:20 UTC (permalink / raw) To: ulf.hansson, robh, krzk+dt, conor+dt, andersson, konradybcio Cc: linux-mmc, devicetree, linux-kernel, neeraj.soni Add an ICE node to kodiak SoC description and enable it by adding a phandle to the SDHC node. Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/kodiak.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi index c2ccbb67f800..de01a6669522 100644 --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi @@ -1045,6 +1045,8 @@ sdhc_1: mmc@7c4000 { qcom,dll-config = <0x0007642c>; qcom,ddr-config = <0x80040868>; + qcom,ice = <&sdhc_ice>; + mmc-ddr-1_8v; mmc-hs200-1_8v; mmc-hs400-1_8v; @@ -1071,6 +1073,13 @@ opp-384000000 { }; }; + sdhc_ice: crypto@7c8000 { + compatible = "qcom,sc7280-inline-crypto-engine", + "qcom,inline-crypto-engine"; + reg = <0x0 0x007c8000 0x0 0x18000>; + clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>; + }; + gpi_dma0: dma-controller@900000 { #dma-cells = <3>; compatible = "qcom,sc7280-gpi-dma", "qcom,sm6350-gpi-dma"; -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-02-16 11:08 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-02-06 11:20 [PATCH v3 0/2] Enable Inline crypto engine for kodiak Neeraj Soni 2026-02-06 11:20 ` [PATCH v3 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle Neeraj Soni 2026-02-06 11:26 ` Krzysztof Kozlowski 2026-02-16 11:05 ` Neeraj Soni 2026-02-16 11:08 ` Krzysztof Kozlowski 2026-02-06 11:20 ` [PATCH v3 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC Neeraj Soni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox