From: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
To: "Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Simek, Michal" <michal.simek@amd.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"git (AMD-Xilinx)" <git@amd.com>,
"saikrishna12468@gmail.com" <saikrishna12468@gmail.com>
Subject: Re: [PATCH] mmc: sdhci-of-arasan: Ensure CD logic stabilization before power-up
Date: Fri, 1 Aug 2025 18:33:44 +0530 [thread overview]
Message-ID: <300b5c01-33bc-4ce6-942c-e32b6e55e5c7@linux.microsoft.com> (raw)
In-Reply-To: <BY5PR12MB425804611D4B29ADDCC82906DB59A@BY5PR12MB4258.namprd12.prod.outlook.com>
Hi Sai Krishna,
On 25-07-2025 11:19, Potthuri, Sai Krishna wrote:
>> Will this work with all Arasan variants?
> Yes, this is expected to work across all Arasan variants that comply with the standard
> SDHCI register definitions. The SDHCI_CD_STABLE bit is defined in both the
> standard SDHCI specification and Arasan's user guide.
As SDHCI_CD_STABLE bit is defined in SDHCI specification, why are you
making a driver specific fix? Is this problem specific to Arasan eMMC?
If not, does it make sense to make this a framework level change instead
of a driver specific change?
Given that you are planning to add a quirk, doing this in common code
would be better.
> On Xilinx/AMD Versal and ZynqMP platforms, the CD stable bit is typically set within
> a few milliseconds. However, to be on the safer side and ensure compatibility across
> all Arasan variants, a timeout of 1 second is added.
> Please let me know if you prefer to increase the timeout or if this logic should be
> enabled by a platform specific quirk.
Thanks,
Prasanna Kumar
next prev parent reply other threads:[~2025-08-01 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 9:53 [PATCH] mmc: sdhci-of-arasan: Ensure CD logic stabilization before power-up Sai Krishna Potthuri
2025-07-24 16:20 ` Adrian Hunter
2025-07-25 5:49 ` Potthuri, Sai Krishna
2025-07-25 8:14 ` Adrian Hunter
2025-07-25 10:53 ` Potthuri, Sai Krishna
2025-08-01 13:03 ` Prasanna Kumar T S M [this message]
2025-08-04 7:11 ` Potthuri, Sai Krishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=300b5c01-33bc-4ce6-942c-e32b6e55e5c7@linux.microsoft.com \
--to=ptsm@linux.microsoft.com \
--cc=adrian.hunter@intel.com \
--cc=git@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=sai.krishna.potthuri@amd.com \
--cc=saikrishna12468@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox