From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Hunter Subject: Re: [PATCH] mmc: tegra: suppress errors when probe is deferred Date: Mon, 21 Aug 2017 16:05:39 +0300 Message-ID: <307ce3c1-0a32-9fce-b68f-63aad2118290@intel.com> References: <1502970766-23541-1-git-send-email-talho@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1502970766-23541-1-git-send-email-talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Timo Alho , thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Cc: linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-mmc@vger.kernel.org On 17/08/17 14:52, Timo Alho wrote: > Don't print error message when clk_get() returns -EPROBE_DEFER. On > recent Tegra chips (t186 onwards), the clocks are provided by > auxiliary microprocessor (bpmp) and until the driver for it is probed > clocks are not available. > > While at it, change the real error message more meaningful. > > Signed-off-by: Timo Alho One comment below, nevertheless: Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-tegra.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index f668a6f..cdde9ff 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -501,8 +501,10 @@ static int sdhci_tegra_probe(struct platform_device *pdev) > > clk = devm_clk_get(mmc_dev(host->mmc), NULL); > if (IS_ERR(clk)) { > - dev_err(mmc_dev(host->mmc), "clk err\n"); > rc = PTR_ERR(clk); > + if (rc != -EPROBE_DEFER) > + dev_err(&pdev->dev, Looks a bit weird sometimes using mmc_dev(host->mmc) and sometimes &pdev->dev. > + "failed to get controller clock: %d\n", rc); > goto err_clk_get; > } > clk_prepare_enable(clk); >