From: 이정승 <js07.lee@samsung.com>
To: "Ulf Hansson" <ulf.hansson@linaro.org>,
이정승 <js07.lee@samsung.com>, linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: Re: [PATCH RESEND] mmc: core: add error message when switching fails in mmc_select_hs()
Date: Wed, 24 Aug 2016 10:21:03 +0000 [thread overview]
Message-ID: <308984994.386450.1472034063955.JavaMail.weblogic@ep1ml103c> (raw)
In-Reply-To: CGME20160824093151epcas1p264895d3724996afc9855663b41ff3466@epcas1p2.samsung.com
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
Hi,
>> @@ -1018,6 +1018,7 @@ static int mmc_switch_status(struct mmc_card *card)
>> */
>> static int mmc_select_hs(struct mmc_card *card)
>> {
>> + struct mmc_host *host = card->host;
>
>No need for local variable here, just use card->host below instead.
Yes, it should be.
>> int err;
>>
>> err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
>> @@ -1029,6 +1030,10 @@ static int mmc_select_hs(struct mmc_card *card)
>> err = mmc_switch_status(card);
>> }
>>
>> + if (err)
>> + pr_err("%s: switch to high-speed failed, err:%d\n",
>> + mmc_hostname(host), err);
>
>I think a pr_warn() would be better as mmc_select_timing() uses the
>legacy speed mode when err == -EBADMSG.
I agree. A modified patch will be sent right after.
Thanks for your comment.
>> +
>> return err;
>> }
>>
>
>Kind regards
>Uffe
prev parent reply other threads:[~2016-08-24 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 9:50 [PATCH RESEND] mmc: core: add error message when switching fails in mmc_select_hs() Jungseung Lee
2016-08-24 9:31 ` Ulf Hansson
[not found] ` <CGME20160824093151epcas1p264895d3724996afc9855663b41ff3466@epcas1p2.samsung.com>
2016-08-24 10:21 ` 이정승 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=308984994.386450.1472034063955.JavaMail.weblogic@ep1ml103c \
--to=js07.lee@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).