From: Adrian Hunter <adrian.hunter@intel.com>
To: Li Zetao <lizetao1@huawei.com>,
patrice.chotard@foss.st.com, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH -next] mmc: sdhci-st: Use devm_platform_ioremap_resource_byname()
Date: Thu, 3 Aug 2023 08:37:45 +0300 [thread overview]
Message-ID: <31e64790-12dc-8537-e099-5e5d633b8e54@intel.com> (raw)
In-Reply-To: <20230802094028.976612-1-lizetao1@huawei.com>
On 2/08/23 12:40, Li Zetao wrote:
> Convert platform_get_resource_byname() + devm_ioremap_resource() to a
> single call to devm_platform_ioremap_resource_byname(), as this is
> exactly what this function does.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-st.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 6415916fbd91..97f350953c4b 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -348,7 +348,6 @@ static int sdhci_st_probe(struct platform_device *pdev)
> struct clk *clk, *icnclk;
> int ret = 0;
> u16 host_version;
> - struct resource *res;
> struct reset_control *rstc;
>
> clk = devm_clk_get(&pdev->dev, "mmc");
> @@ -397,9 +396,7 @@ static int sdhci_st_probe(struct platform_device *pdev)
> }
>
> /* Configure the FlashSS Top registers for setting eMMC TX/RX delay */
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> - "top-mmc-delay");
> - pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> + pdata->top_ioaddr = devm_platform_ioremap_resource_byname(pdev, "top-mmc-delay");
> if (IS_ERR(pdata->top_ioaddr))
> pdata->top_ioaddr = NULL;
>
next prev parent reply other threads:[~2023-08-03 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 9:40 [PATCH -next] mmc: sdhci-st: Use devm_platform_ioremap_resource_byname() Li Zetao
2023-08-03 5:37 ` Adrian Hunter [this message]
2023-08-08 10:52 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31e64790-12dc-8537-e099-5e5d633b8e54@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=patrice.chotard@foss.st.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox