From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Ritesh Harjani <riteshh@codeaurora.org>
Subject: Re: [PATCH 1/1] mmc: core: Further fix thread wake-up
Date: Tue, 20 Dec 2016 18:41:04 +0100 [thread overview]
Message-ID: <3356533.yTje0Ng7LW@amdc3058> (raw)
In-Reply-To: <CAPDyKFpB+dWJ55E_DncKv5q0TBqXyYRcg0eEHWcVsQ+8x1TPnA@mail.gmail.com>
Hi,
On Tuesday, December 20, 2016 11:56:23 AM Ulf Hansson wrote:
> On 19 December 2016 at 14:57, Adrian Hunter <adrian.hunter@intel.com> wrote:
> > Commit e0097cf5f2f1 ("mmc: queue: Fix queue thread wake-up") did not go far
> > enough. mmc_wait_for_data_req_done() still contains some problems and can
> > be further simplified. First it should not touch
> > context_info->is_waiting_last_req because that is a wake-up control used by
> > the owner of the context. Secondly, it should always return when one of its
> > wake-up conditions is met because, again, that is contolled by the owner of
> > the context.
> >
> > While the current block driver does not have an issue, these problems were
> > exposed during testing of the Software Command Queue patches.
This sentence no longer seems to be true..
> > Fixes: e0097cf5f2f1 ("mmc: queue: Fix queue thread wake-up")
> > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Thanks, applied for fixes!
Seems that I'm late but FWIW for the patch content:
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2016-12-20 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 13:57 [PATCH 0/1] mmc: core: Further fix thread wake-up Adrian Hunter
2016-12-19 13:57 ` [PATCH 1/1] " Adrian Hunter
2016-12-19 15:52 ` Ritesh Harjani
2016-12-20 10:56 ` Ulf Hansson
2016-12-20 17:41 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3356533.yTje0Ng7LW@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=riteshh@codeaurora.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox