Re: [PATCH] mmc: dw_mmc-rockchip: Fix wrong internal phase calculate

[Heiko Stuebner <heiko@sntech.de>]

Am Dienstag, 4. November 2025, 04:51:23 Mitteleuropäische Normalzeit schrieb Shawn Lin:
> ciu clock is 2 times of io clock, but the sample clk used is
> derived from io clock provided to the card. So we should use
> io clock to calculate the phase.
> 
> Fixes: 59903441f5e4 ("mmc: dw_mmc-rockchip: Add internal phase support")
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Acked-by: Heiko Stuebner <heiko@sntech.de>

> ---
> 
>  drivers/mmc/host/dw_mmc-rockchip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index 82dd906..6813549 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -42,7 +42,7 @@ struct dw_mci_rockchip_priv_data {
>   */
>  static int rockchip_mmc_get_internal_phase(struct dw_mci *host, bool sample)
>  {
> -	unsigned long rate = clk_get_rate(host->ciu_clk);
> +	unsigned long rate = clk_get_rate(host->ciu_clk) / RK3288_CLKGEN_DIV;
>  	u32 raw_value;
>  	u16 degrees;
>  	u32 delay_num = 0;
> @@ -85,7 +85,7 @@ static int rockchip_mmc_get_phase(struct dw_mci *host, bool sample)
>  
>  static int rockchip_mmc_set_internal_phase(struct dw_mci *host, bool sample, int degrees)
>  {
> -	unsigned long rate = clk_get_rate(host->ciu_clk);
> +	unsigned long rate = clk_get_rate(host->ciu_clk) / RK3288_CLKGEN_DIV;
>  	u8 nineties, remainder;
>  	u8 delay_num;
>  	u32 raw_value;
>