Re: [RFC PATCH] mmc: mmc_oops: support mmc_oops feature

[Arnd Bergmann <arnd@arndb.de>]

On Friday 27 February 2015 18:42:29 Jaehoon Chung wrote:
> Dear, Arnd.
> 
> On 02/27/2015 05:31 PM, Arnd Bergmann wrote:
> > On Friday 27 February 2015 14:33:39 Jaehoon Chung wrote:
> >> --- a/drivers/mmc/card/Kconfig
> >> +++ b/drivers/mmc/card/Kconfig
> >> @@ -68,3 +68,11 @@ config MMC_TEST
> >>  
> >>           This driver is only of interest to those developing or
> >>           testing a host driver. Most people should say N here.
> >> +
> >> +config MMC_OOPS
> >> +       tristate "Log panic/oops to a MMC buffer"
> >> +       depends on OF
> >> +       help
> >> +         This enables panic and oops messages to be logged to a circular
> >> +         buffer in a MMC sectors where it can be read back at some
> >> +         later point.
> >>
> > 
> > This sounds a lot like the implementation should be using
> > the fs/pstore infrastructure like we do for ramoops, chromeos
> > and the EFI runtime services logger.
> 
> I refer to it, so you can sound so. It's my wrong.
> I will rewrite the comment for MMC_OOPS config.
> Thanks for point out.

I don't exactly understand what you mean here, but I meant rewriting
the patch, not just the comment.

	Arnd