Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Satyansh Shukla <satyansh.shukla@oracle.com>,
	Ulf Hansson <ulfh@kernel.org>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: dwcmshc_bf3_hw_reset: Log eMMC reset calls
Date: Fri, 3 Jul 2026 16:41:07 +0300	[thread overview]
Message-ID: <3425c3da-86fd-469d-a3ec-7805138d3e2e@intel.com> (raw)
In-Reply-To: <20260618105319.217717-1-satyansh.shukla@oracle.com>

On 18/06/2026 13:53, Satyansh Shukla wrote:
> Log when the BlueField-3 eMMC hardware reset path is invoked and
> whether the RST_N SMC call succeeds.
> 
> This makes it easier to diagnose cases where the controller recovery path
> depends on issuing an eMMC reset, and helps confirm that the reset sequence
> was attempted on affected systems.
> 
> Signed-off-by: Satyansh Shukla <satyansh.shukla@oracle.com>
> ---
>  drivers/mmc/host/sdhci-of-dwcmshc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index b9ecd91f44ad..8acd4652a12b 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -2019,10 +2019,13 @@ static void dwcmshc_bf3_hw_reset(struct sdhci_host *host)
>  {
>  	struct arm_smccc_res res = { 0 };
>  
> +	pr_info("%s: resetting...\n", __func__);
>  	arm_smccc_smc(BLUEFIELD_SMC_SET_EMMC_RST_N, 0, 0, 0, 0, 0, 0, 0, &res);
>  
>  	if (res.a0)
>  		pr_err("%s: RST_N failed.\n", mmc_hostname(host->mmc));
> +	else
> +		pr_info("%s: RST_N succeeded.\n", mmc_hostname(host->mmc));

Diagnostic prints need to be pr_debug().  Also 1 print should be enough.

>  }
>  
>  static const struct sdhci_ops sdhci_dwcmshc_bf3_ops = {


  parent reply	other threads:[~2026-07-03 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 10:53 [PATCH] mmc: dwcmshc_bf3_hw_reset: Log eMMC reset calls Satyansh Shukla
2026-07-01 17:24 ` [External] : " Satyansh Shukla
2026-07-03 13:41 ` Adrian Hunter [this message]
2026-07-06 12:33   ` [PATCH v2] " Satyansh Shukla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3425c3da-86fd-469d-a3ec-7805138d3e2e@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=satyansh.shukla@oracle.com \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox