From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D34EC4332F for ; Mon, 6 Nov 2023 06:39:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230371AbjKFGjB (ORCPT ); Mon, 6 Nov 2023 01:39:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230312AbjKFGi7 (ORCPT ); Mon, 6 Nov 2023 01:38:59 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 183DAF2; Sun, 5 Nov 2023 22:38:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699252737; x=1730788737; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wvdbe6zVR8rZcC9nQE2AwaoKXs2J2UvptwC3bmJCfP0=; b=alK7wG2wLBbrNywBuHIIwE84JlTcaeiEDTEjC+yXmoxAfPrcYD+Mnwzn E9PoDByvjxeB7Q7CCwsMQv/7CMU/a+gmOpfFSq/CygvWF8QQHx8v0ZdT8 Kzv2D3q93HZHSp8EHXShkp1nZxErzTLdjHyOm6ivzDV8zLOmFtXnt/D4z 9damhoKkkdNSA6RFkpfbSJkHa7QHxFPztlQgGckbj2aYsbDpMdV/HZRGA adX0o+sBr9wEUg4vqT28CqGO9DAq7K8URtW+NdyoX8Ag1NlaL08eZao58 Ea6ScNaPRuszyf2JmC9w2UY/hDLq+1mE8R+7qwQVwt5VkSRu9bEYLiOhA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="388099119" X-IronPort-AV: E=Sophos;i="6.03,280,1694761200"; d="scan'208";a="388099119" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2023 22:38:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="1093683958" X-IronPort-AV: E=Sophos;i="6.03,280,1694761200"; d="scan'208";a="1093683958" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.251.215.231]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2023 22:38:50 -0800 Message-ID: <34fde333-411a-4345-b940-4a34d45b499e@intel.com> Date: Mon, 6 Nov 2023 08:38:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 0/6] mmc: block: Fixes for CQE error recovery recovery Content-Language: en-US To: Avri Altman , Ulf Hansson , =?UTF-8?Q?Kornel_Dul=C4=99ba?= , Radoslaw Biernacki , Gwendal Grignou , Asutosh Das Cc: Chaotian Jing , Bhavya Kapoor , Kamal Dasu , Al Cooper , Haibo Chen , Shaik Sajida Bhanu , Sai Krishna Potthuri , Victor Shih , Ben Chuang , Thierry Reding , Aniruddha Tvs Rao , Chun-Hung Wu , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20231103084720.6886-1-adrian.hunter@intel.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 3/11/23 12:10, Avri Altman wrote: > Does the double "recovery" in the subject intentional? No, must be an echo in here > > Thanks, > Avri > >> Hi >> >> Some issues have been found with CQE error recovery. Here are some fixes. >> >> As of V2, the alternative implementation for the patch from Kornel Dulęba: >> >> https://lore.kernel.org/linux-mmc/e7c12e07-7540-47ea-8891- >> 2cec73d58df1@intel.com/T/#u >> >> is now included, see patch 6 "mmc: cqhci: Fix task clearing in CQE error >> recovery") >> >> Please also note ->post_disable() seems to be missing from >> cqhci_recovery_start(). It would be good if ->post_disable() users could >> check if this needs attention. >> >> >> Changes in V2: >> >> mmc: cqhci: Fix task clearing in CQE error recovery >> New patch >> >> mmc: cqhci: Warn of halt or task clear failure >> Add fixes and stable tags >> >> >> Adrian Hunter (6): >> mmc: block: Do not lose cache flush during CQE error recovery >> mmc: cqhci: Increase recovery halt timeout >> mmc: block: Be sure to wait while busy in CQE error recovery >> mmc: block: Retry commands in CQE error recovery >> mmc: cqhci: Warn of halt or task clear failure >> mmc: cqhci: Fix task clearing in CQE error recovery >> >> drivers/mmc/core/block.c | 2 ++ >> drivers/mmc/core/core.c | 9 +++++++-- >> drivers/mmc/host/cqhci-core.c | 44 +++++++++++++++++++++----------------- >> ----- >> 3 files changed, 31 insertions(+), 24 deletions(-) >> >> >> Regards >> Adrian