From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adam Ford <aford173@gmail.com>, linux-arm-kernel@lists.infradead.org
Cc: aford@beaconembedded.com, Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: mmc: imx-esdhc: Change imx8mn and imx8mp compatible fallback
Date: Wed, 23 Mar 2022 14:56:09 +0100 [thread overview]
Message-ID: <35f58894-ed6d-0af0-e483-7a161ad6625a@kernel.org> (raw)
In-Reply-To: <20220323134019.3796178-1-aford173@gmail.com>
On 23/03/2022 14:40, Adam Ford wrote:
> The SDHC controller in the imx8mn and imx8mp have the same controller
> as the imx8mm which is slightly different than that of the imx7d.
> Using the fallback of the imx8mm enables the controllers to support
> HS400-ES which is not available on the imx7d.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index 7dbbcae9485c..d6ea73d76bdd 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -39,14 +39,14 @@ properties:
> - items:
> - enum:
> - fsl,imx8mm-usdhc
Your change looks reasonable, but why imx8mm is compatible with imx7d?
> - - fsl,imx8mn-usdhc
> - - fsl,imx8mp-usdhc
> - fsl,imx8mq-usdhc
> - fsl,imx8qm-usdhc
> - fsl,imx8qxp-usdhc
> - const: fsl,imx7d-usdhc
> - items:
> - enum:
> + - fsl,imx8mn-usdhc
> + - fsl,imx8mp-usdhc
> - fsl,imx93-usdhc
> - fsl,imx8ulp-usdhc
> - const: fsl,imx8mm-usdhc
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-23 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 13:40 [PATCH 1/3] dt-bindings: mmc: imx-esdhc: Change imx8mn and imx8mp compatible fallback Adam Ford
2022-03-23 13:40 ` [PATCH 2/3] arm64: dts: imx8mn: Enable HS400-ES Adam Ford
2022-03-23 13:40 ` [PATCH 3/3] arm64: dts: imx8mp: " Adam Ford
2022-03-23 13:56 ` Krzysztof Kozlowski [this message]
2022-03-23 14:00 ` [PATCH 1/3] dt-bindings: mmc: imx-esdhc: Change imx8mn and imx8mp compatible fallback Adam Ford
2022-03-23 14:11 ` Krzysztof Kozlowski
2022-03-23 17:23 ` Adam Ford
2022-03-24 2:54 ` Bough Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35f58894-ed6d-0af0-e483-7a161ad6625a@kernel.org \
--to=krzk@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox