* [PATCH 3/3] mmc: sdhci: Modify sdhci o2 quirk for eMMC HS200 tuning case [not found] <BN1PR04MB4543C8987923D893F407934893C0@BN1PR04MB454.namprd04.prod.outlook.com> @ 2017-12-04 10:10 ` LinuxPatchCommit 2017-12-19 8:37 ` Adrian Hunter 0 siblings, 1 reply; 2+ messages in thread From: LinuxPatchCommit @ 2017-12-04 10:10 UTC (permalink / raw) To: adrian.hunter@intel.com, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: LinuxPatchCommit, Shirley Her (SC) Dear all, Don't clear transfer mode register in sdhci_set_transfer_mode(). In sdhci_set_transfer_mode(), clear transfer mode quirk2 will clear SD host transfer mode register for non-data commands. This quirk is used for the bug of O2micro/Bayhubtech devices. In eMMC HS200 tuning case, the tuning process uses hardware tuning and it needs to set transfer mode register for tuning command. Signed-off-by: ernest.zhang <ernest.zhang@bayhubtech.com> --- drivers/mmc/host/sdhci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 0d5fcca18c9e..d5b19fc9ea56 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -918,7 +918,9 @@ static void sdhci_set_transfer_mode(struct sdhci_host *host, if (data == NULL) { if (host->quirks2 & SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD) { - sdhci_writew(host, 0x0, SDHCI_TRANSFER_MODE); + /* cannot clear transfer mode register when tuning */ + if (cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200) + sdhci_writew(host, 0x0, SDHCI_TRANSFER_MODE); } else { /* clear Auto CMD settings for no data CMDs */ mode = sdhci_readw(host, SDHCI_TRANSFER_MODE); -- 2.14.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] mmc: sdhci: Modify sdhci o2 quirk for eMMC HS200 tuning case 2017-12-04 10:10 ` [PATCH 3/3] mmc: sdhci: Modify sdhci o2 quirk for eMMC HS200 tuning case LinuxPatchCommit @ 2017-12-19 8:37 ` Adrian Hunter 0 siblings, 0 replies; 2+ messages in thread From: Adrian Hunter @ 2017-12-19 8:37 UTC (permalink / raw) To: LinuxPatchCommit, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shirley Her (SC) On 04/12/17 12:10, LinuxPatchCommit wrote: > Dear all, > > Don't clear transfer mode register in sdhci_set_transfer_mode(). > > In sdhci_set_transfer_mode(), clear transfer mode quirk2 will clear SD host transfer mode register for non-data commands. This quirk is used for the bug of O2micro/Bayhubtech devices. In eMMC HS200 tuning case, the tuning process uses hardware tuning and it needs to set transfer mode register for tuning command. > > Signed-off-by: ernest.zhang <ernest.zhang@bayhubtech.com> > --- > drivers/mmc/host/sdhci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 0d5fcca18c9e..d5b19fc9ea56 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -918,7 +918,9 @@ static void sdhci_set_transfer_mode(struct sdhci_host *host, > if (data == NULL) { > if (host->quirks2 & > SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD) { > - sdhci_writew(host, 0x0, SDHCI_TRANSFER_MODE); > + /* cannot clear transfer mode register when tuning */ > + if (cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200) > + sdhci_writew(host, 0x0, SDHCI_TRANSFER_MODE); In the HS200 case you are sending the tuning command with data, so I do not understand why you need this i.e. you will never get here > } else { > /* clear Auto CMD settings for no data CMDs */ > mode = sdhci_readw(host, SDHCI_TRANSFER_MODE); > -- > 2.14.1 > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-19 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <BN1PR04MB4543C8987923D893F407934893C0@BN1PR04MB454.namprd04.prod.outlook.com>
2017-12-04 10:10 ` [PATCH 3/3] mmc: sdhci: Modify sdhci o2 quirk for eMMC HS200 tuning case LinuxPatchCommit
2017-12-19 8:37 ` Adrian Hunter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox