From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7339CC0015E for ; Wed, 26 Jul 2023 06:45:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230205AbjGZGpl (ORCPT ); Wed, 26 Jul 2023 02:45:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbjGZGpR (ORCPT ); Wed, 26 Jul 2023 02:45:17 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59581F3; Tue, 25 Jul 2023 23:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690353916; x=1721889916; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=E0NopSXKtSx71VotkiqKSZjtHpk8QWrhSGVmlfa96+E=; b=ntNCWJTkjM7tAJfNSiPxtAW8oETSzeIq25uTQQ3ZjZfMnb3056+Oi5pW VHupPV1gFhklEFE1dxsDVagQPOhrhwvCmTf88nK1kirUyB5iFwS7KE5mB sv0XCcnT0KFbSthZndembi70qICWI5yL6voMzxpGAF6WOOKwfsYS807P6 0w9muOvS5BFNAplb0wEWgI66L+80lvpjAf1xLF63b7KT1FEkyKDNXEMFD 3xUo1mDYN3Y9q37gS5KgUsX17ax1xCN0ZihFJ6rUhZUo4pDZ6JWb5GmLJ faR30CiEW4IH3GOfjSTkyaEyJ+kpdxYpwApUU12R6VXvj2QdBzOx9jRQA A==; X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="348205567" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="348205567" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 23:45:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="900282908" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="900282908" Received: from igosu-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.252.35.75]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 23:45:12 -0700 Message-ID: <382abd40-94c3-bd2a-a3a7-4fdaa195c781@intel.com> Date: Wed, 26 Jul 2023 09:45:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH v2 33/61] mmc: sdhci-of-aspeed: remove unneeded variables Content-Language: en-US To: Yangtao Li , Andrew Jeffery , Ulf Hansson , Joel Stanley Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230726040041.26267-1-frank.li@vivo.com> <20230726040041.26267-33-frank.li@vivo.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20230726040041.26267-33-frank.li@vivo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 26/07/23 07:00, Yangtao Li wrote: > The variable 'dead' is redundant, let's remove it. > > Signed-off-by: Yangtao Li Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-of-aspeed.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c > index 25b4073f698b..b4867bb4a564 100644 > --- a/drivers/mmc/host/sdhci-of-aspeed.c > +++ b/drivers/mmc/host/sdhci-of-aspeed.c > @@ -454,12 +454,11 @@ static int aspeed_sdhci_remove(struct platform_device *pdev) > { > struct sdhci_pltfm_host *pltfm_host; > struct sdhci_host *host; > - int dead = 0; > > host = platform_get_drvdata(pdev); > pltfm_host = sdhci_priv(host); > > - sdhci_remove_host(host, dead); > + sdhci_remove_host(host, 0); > > clk_disable_unprepare(pltfm_host->clk); >