Re: [PATCH] mmc: moxart-mmc: Fix APP_CMD flag set on non-application commands

[Arnd Bergmann <arnd@arndb.de>]

On Tuesday, June 7, 2016 10:53:01 AM CEST Michal Kadlic wrote:
> Moxart MMC host controller has an APP_CMD flag, that's set when sending 
> an ACMD. This was set by checking command opcode instead of CMD55->ACMDx 
> sequence, which could lead to regular commands like CMD6,CMD13,CMD23 and 
> CMD42 flagged as application commands.
> 
> Patch is against kernel version 4.6
> 
> Signed-off-by: Michal Kadlic <michal.kadlic@spinet.sk>

Is this needed for backports to stable kernels as well?

>   static inline void moxart_init_sg(struct moxart_host *host,
> @@ -211,10 +213,11 @@ static void moxart_send_command(struct m
>          writel(cmd->arg, host->base + REG_ARGUMENT);
> 
>          cmdctrl = cmd->opcode & CMD_IDX_MASK;
> -       if (cmdctrl == SD_APP_SET_BUS_WIDTH    || cmdctrl == 
> SD_APP_OP_COND   ||
> -           cmdctrl == SD_APP_SEND_SCR         || cmdctrl == 
> SD_APP_SD_STATUS ||
> -           cmdctrl == SD_APP_SEND_NUM_WR_BLKS)
> +

You seem to have an incorrect word wrapping setting in your email
client, so the patch won't apply. I'd recommend using 'git send-email',
which tends to be easier than figuring out the right settings for your
mailer.

> +       // If previous command was CMD55 set APP_CMD flag, except for 
> CMD0(Reset)

Please use /* ... */ comments.

	Arnd