From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board Date: Wed, 08 Oct 2014 14:07:48 +0200 Message-ID: <3871564.7PhRGhHd6U@wuerfel> References: <2750153.I3nVqzmXTP@amdc1032> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([212.227.126.131]:55867 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756739AbaJHMIl (ORCPT ); Wed, 8 Oct 2014 08:08:41 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: Bartlomiej Zolnierkiewicz , Kukjin Kim , Doug Anderson , Yuvaraj Kumar C D , "cpgs ." , Yuvaraj Kumar C D , linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , Jaehoon Chung , Chris Ball , Seung-Won Jeon , linux-mmc , Sonny Rao , Tomasz Figa , SUNIL JOSHI , PRASHANTH GODREHAL , ALIM AKHTAR , Javier Martinez Canillas , Abhilash Kesavan On Thursday 02 October 2014 20:16:44 Ulf Hansson wrote: > On 2 October 2014 18:10, Bartlomiej Zolnierkiewicz > wrote: > > Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc > > and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc. Currently the device > > tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and vqmmc is > > not specified. Fix it. > > > > Without this patch: > > - "mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators" > > patch causes a SD card detection to fail > > - "mmc: dw_mmc: Support voltage changes" patch causes a boot hang > > > > This patch fixes both above problems. > > > > Suggested-by: Doug Anderson > > Cc: Yuvaraj Kumar C D > > Cc: Ulf Hansson > > Signed-off-by: Bartlomiej Zolnierkiewicz > > Acked-by: Kyungmin Park > > Unless it causes a bunch non-trivial conflicts, I suggest we take this > through my mmc tree to not break bisectability. Have you tried if it conflicts with arm-soc? If not, Acked-by: Arnd Bergmann