From: Arnd Bergmann <arnd@arndb.de>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH/RFC v3 1/6] mmc: sh_mobile_sdhi, tmio: make dma more modular
Date: Wed, 06 Jul 2016 22:43:26 +0200 [thread overview]
Message-ID: <3888420.7E5mgG7hxa@wuerfel> (raw)
In-Reply-To: <1467836610-18539-2-git-send-email-horms+renesas@verge.net.au>
On Wednesday, July 6, 2016 10:23:25 PM CEST Simon Horman wrote:
>
> +static struct tmio_mmc_dma_ops tmio_dma_ops;
> +
> +void tmio_set_dma_ops(const struct tmio_mmc_dma_ops *ops)
> +{
> + tmio_dma_ops = *ops;
> +}
> +EXPORT_SYMBOL(tmio_set_dma_ops);
> +
>
Having a global instance of this pointer seems wrong, why not
store the pointer per device in struct tmio_mmc_host?
It's unlikely to ever clash between two devices in the same system,
but we generally try not to rely on that.
Arnd
next prev parent reply other threads:[~2016-07-06 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 20:23 [PATCH/RFC v3 0/6] mmc: renesas_sdhi: add R-Car Gen-3 DMA support Simon Horman
2016-07-06 20:23 ` [PATCH/RFC v3 1/6] mmc: sh_mobile_sdhi, tmio: make dma more modular Simon Horman
2016-07-06 20:43 ` Arnd Bergmann [this message]
2016-07-06 20:23 ` [PATCH/RFC v3 2/6] mmc: sh_mobile_sdhi: rename DMA source file as renesas_sdhi_sys_dmac.c Simon Horman
2016-07-06 20:23 ` [PATCH/RFC v3 3/6] mmc: tmio: add max_segs and max_blk_count in tmio_mmc_data Simon Horman
2016-07-06 20:23 ` [PATCH/RFC v3 4/6] mmc: sh_mobile_sdhi: add some SoC specific data for R-Car Gen3 Simon Horman
2016-07-06 20:23 ` [PATCH/RFC v3 5/6] mmc: renesas_sdhi: add support for R-Car Gen3 SDHI DMAC Simon Horman
2016-07-06 21:21 ` Arnd Bergmann
2016-07-07 6:57 ` Simon Horman
2016-07-06 20:23 ` [PATCH/RFC v3 6/6] arm64: defconfig: Enable SDHI SD/SDIO controller Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3888420.7E5mgG7hxa@wuerfel \
--to=arnd@arndb.de \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox