Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Luke Wang" <ziniu.wang_1@nxp.com>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Haibo Chen" <haibo.chen@nxp.com>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>
Cc: "Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Josua Mayer" <josua@solid-run.com>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-mmc @ vger . kernel . org" <linux-mmc@vger.kernel.org>,
	"NXP S32 Linux Team" <S32@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] [PATCH] [v2] mmc: esdhc-imx: convert to modern PM_OPS
Date: Tue, 15 Apr 2025 14:57:21 +0200	[thread overview]
Message-ID: <3d544dbc-863d-4ac5-9839-aef3a36881d1@app.fastmail.com> (raw)
In-Reply-To: <DU2PR04MB856729305860ED5C3C545771EDB22@DU2PR04MB8567.eurprd04.prod.outlook.com>

On Tue, Apr 15, 2025, at 05:15, Luke Wang wrote:
> Hi Arnd,
>
> This patch has compilation issue because sdhci.c still uses #ifdef 
> CONFIG_PM. Do you plan to send a new patch to fix? If not, I can send a 
> patch to fix the compilation warning.

Can you see if the change below is sufficient? I see I have that
in my randconfig tree and I did not see any problems with my
v2 patch and that. I probably added that one originally because
of some other build failure but then never sent it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index cd0e35a80542..4ee2695b0202 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -874,12 +874,10 @@ irqreturn_t sdhci_thread_irq(int irq, void *dev_id);
 void sdhci_adma_write_desc(struct sdhci_host *host, void **desc,
                           dma_addr_t addr, int len, unsigned int cmd);
 
-#ifdef CONFIG_PM
 int sdhci_suspend_host(struct sdhci_host *host);
 int sdhci_resume_host(struct sdhci_host *host);
 int sdhci_runtime_suspend_host(struct sdhci_host *host);
 int sdhci_runtime_resume_host(struct sdhci_host *host, int soft_reset);
-#endif
 
 void sdhci_cqe_enable(struct mmc_host *mmc);
 void sdhci_cqe_disable(struct mmc_host *mmc, bool recovery);

  reply	other threads:[~2025-04-15 12:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11  8:59 [PATCH] [v2] mmc: esdhc-imx: convert to modern PM_OPS Arnd Bergmann
2025-04-11 11:02 ` [EXT] " Luke Wang
2025-04-11 11:47   ` Adrian Hunter
2025-04-14  6:49     ` Luke Wang
2025-04-14  8:08 ` kernel test robot
2025-04-14 10:32 ` kernel test robot
2025-04-15  3:15 ` [EXT] " Luke Wang
2025-04-15 12:57   ` Arnd Bergmann [this message]
2025-04-16  2:42     ` Luke Wang
2025-04-16 17:47 ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d544dbc-863d-4ac5-9839-aef3a36881d1@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=S32@nxp.com \
    --cc=adrian.hunter@intel.com \
    --cc=arnd@kernel.org \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=josua@solid-run.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=ziniu.wang_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox