From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A44C433E0 for ; Fri, 19 Jun 2020 13:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D69C9208C7 for ; Fri, 19 Jun 2020 13:41:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="EAza6L48" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729509AbgFSNlf (ORCPT ); Fri, 19 Jun 2020 09:41:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730512AbgFSNle (ORCPT ); Fri, 19 Jun 2020 09:41:34 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00A78C06174E for ; Fri, 19 Jun 2020 06:41:32 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id q19so11572472lji.2 for ; Fri, 19 Jun 2020 06:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0kfiprTxlQMET0aohY6CHO3ZmdD0jejABT0PH5mAi/Q=; b=EAza6L48w9+SNbvVEP0eEozOKI5N1A+Co/IBc8tRmMIgoSCTFMGDSP7/oIB+O2MHYW assCCPO4hfdYV0Ze5OlMUdb273rPm8Fq+kxz5IgRdGLu1up4Mfr6YhpoBN5ap5vZPWkx 8aDMNIAF+S1xF7WXfr7/jMkdLf5+A6nMLsvX0SNi4zOkHPZFMFAm/yUR4msTWopzjJCB qUh7UktR2gAKsGfEJcUie55XnKd2sIRMMlQ+qvEI7v3IxyatnepPSIkCLkInyHk4m/4Z 31RLh9OA1m9dmgBz9/O6yWwOfD40qovV3gjIm9KbQ97KM6HXJBN3e/QyhbygGxeKE27K U4UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0kfiprTxlQMET0aohY6CHO3ZmdD0jejABT0PH5mAi/Q=; b=ugs8U7ZGBPVxou3xFp9bKGzd/SF7vToRKFAcvPWxOo36ZDz1NfTZjr10tEFMZ3SErS dg2CMicp0l/PX+SanT92ysUmjFChr4NFDLWVuYnny50hqzsuVFzWA5v6iKgVmrp4KXwL YnGaYPPdx2Nm/MWgQ+Y1MitN7l6pkXBqIB5szMUUrUPdZAIeibTsJNQ2IbOgrknkEldG KbmatOG4EpSxrXNecY7uJaaaVl/Fgg1KqARyl4jw1J1ufaHw1AUlXaS0FkjgMjRPBHqx 8mIMmGbQsUFiOU9HRMYD5O7QWIlGoqRnGUBrgUFoeh3LUM/SEOtNIpTSqQMKEQKmStOV K8zw== X-Gm-Message-State: AOAM532ufFEplCXM2Sczsvs9jIIJy7R4eScGc8PLoCPXRHk3pnrxLuPa l+kInhNWqeZy9ebPVQvt4LCkTQ== X-Google-Smtp-Source: ABdhPJxnmszfRP4BClRPvSzMiOpj7oIM647dZLiP0cGAkcAAwikq/uA+QtkCQal5+K2WmjHVy9EE8w== X-Received: by 2002:a2e:9246:: with SMTP id v6mr1952220ljg.47.1592574091342; Fri, 19 Jun 2020 06:41:31 -0700 (PDT) Received: from [192.168.1.100] ([213.87.147.213]) by smtp.gmail.com with ESMTPSA id u6sm1179747ljk.109.2020.06.19.06.41.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2020 06:41:30 -0700 (PDT) Subject: Re: [PATCH/RFC v2 2/2] mmc: core: Call mmc_power_off_nofity() if pm_suspend_via_firmware() To: Yoshihiro Shimoda , mark.rutland@arm.com, lorenzo.pieralisi@arm.com, ulf.hansson@linaro.org Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org References: <1592566143-4546-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1592566143-4546-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> From: Sergei Shtylyov Message-ID: <3d91f688-d79a-7d50-a9ac-e08ea2d0cd31@cogentembedded.com> Date: Fri, 19 Jun 2020 16:41:15 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <1592566143-4546-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hello! On 19.06.2020 14:29, Yoshihiro Shimoda wrote: > If pm_suspend_via_firmware() returns true, the system will be able > to cut both vcc and vccq in the suspend. So, call > mmc_power_off_nofity() if pm_suspend_via_firmware() returns true. mmc_poweroff_notify()? :-) > Note that we should not update the MMC_CAP2_FULL_PWR_CYCLE caps > because the mmc_select_voltage() checks the caps when attaches > a mmc/sd. > > Signed-off-by: Yoshihiro Shimoda > --- > drivers/mmc/core/mmc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index 4203303..81941fd 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c [...] > @@ -2038,7 +2039,8 @@ static int _mmc_suspend(struct mmc_host *host, bool is_suspend) > goto out; > > if (mmc_can_poweroff_notify(host->card) && > - ((host->caps2 & MMC_CAP2_FULL_PWR_CYCLE) || !is_suspend)) > + ((host->caps2 & MMC_CAP2_FULL_PWR_CYCLE) || !is_suspend || > + pm_suspend_via_firmware())) > err = mmc_poweroff_notify(host->card, notify_type); > else if (mmc_can_sleep(host->card)) > err = mmc_sleep(host); > MBR, Sergei