From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ritesh Harjani Subject: Re: [PATCH] mmc: mmc_test: Fix "Commands during non-blocking write" tests Date: Mon, 7 Nov 2016 11:40:48 +0530 Message-ID: <41a2be09-2d50-335c-2045-88041e56a7f3@codeaurora.org> References: <1478259665-13406-1-git-send-email-adrian.hunter@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:54526 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcKGGKx (ORCPT ); Mon, 7 Nov 2016 01:10:53 -0500 In-Reply-To: <1478259665-13406-1-git-send-email-adrian.hunter@intel.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Adrian Hunter , Ulf Hansson Cc: linux-mmc Hi, On 11/4/2016 5:11 PM, Adrian Hunter wrote: > mmc_test_check_result_async() requires that struct mmc_async_req is > contained within struct mmc_test_async_req. Fix the "Commands during > non-blocking write" tests so that is the case. Tested this patch on an internal platform. Fixes the issue with mmc_test. Tested-by: Ritesh Harjani > > Fixes: 4bbb9aac9a9a ("mmc: mmc_test: Add tests for sending commands during transfer") > Signed-off-by: Adrian Hunter > --- > drivers/mmc/card/mmc_test.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c > index 5a8dc5a76e0d..3678220964fe 100644 > --- a/drivers/mmc/card/mmc_test.c > +++ b/drivers/mmc/card/mmc_test.c > @@ -2347,7 +2347,7 @@ static int mmc_test_ongoing_transfer(struct mmc_test_card *test, > struct mmc_test_req *rq = mmc_test_req_alloc(); > struct mmc_host *host = test->card->host; > struct mmc_test_area *t = &test->area; > - struct mmc_async_req areq; > + struct mmc_test_async_req test_areq = { .test = test }; > struct mmc_request *mrq; > unsigned long timeout; > bool expired = false; > @@ -2363,8 +2363,8 @@ static int mmc_test_ongoing_transfer(struct mmc_test_card *test, > mrq->sbc = &rq->sbc; > mrq->cap_cmd_during_tfr = true; > > - areq.mrq = mrq; > - areq.err_check = mmc_test_check_result_async; > + test_areq.areq.mrq = mrq; > + test_areq.areq.err_check = mmc_test_check_result_async; > > mmc_test_prepare_mrq(test, mrq, t->sg, t->sg_len, dev_addr, t->blocks, > 512, write); > @@ -2378,7 +2378,7 @@ static int mmc_test_ongoing_transfer(struct mmc_test_card *test, > > /* Start ongoing data request */ > if (use_areq) { > - mmc_start_req(host, &areq, &ret); > + mmc_start_req(host, &test_areq.areq, &ret); > if (ret) > goto out_free; > } else { > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project