From: Ricky WU <ricky_wu@realtek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 0/4] mmc: rtsx_usb_sdmmc: Improve sd_set_power_mode()
Date: Thu, 19 Jun 2025 02:27:23 +0000 [thread overview]
Message-ID: <4273aceac8104c6a95bcf94be2a6e567@realtek.com> (raw)
In-Reply-To: CAPDyKFpWrBDQjUdGkhnRVxrYGLMfqmyd9U8Kv44aRZWwhqTG3A@mail.gmail.com
> -----Original Message-----
> From: Ricky WU
> Sent: Wednesday, June 18, 2025 10:48 AM
> To: 'Ulf Hansson' <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Subject: RE: [PATCH 0/4] mmc: rtsx_usb_sdmmc: Improve
> sd_set_power_mode()
>
> > On Tue, 10 Jun 2025 at 13:16, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > >
> > > The code in sd_set_power_mode() is a bit obfuscated and also has
> > > some minor issue in its error-path. This small series addresses these
> problems.
> > >
> > > Ulf Hansson (4):
> > > mmc: rtsx_usb_sdmmc: Fix error-path in sd_set_power_mode()
> > > mmc: rtsx_usb_sdmmc: Print debug-messages at power-on/off errors
> > > mmc: rtsx_usb_sdmmc: Convert sd_set_power_mode() into void
> > > mmc: rtsx_usb_sdmmc: Re-work the code in sd_set_power_mode()
> > >
> > > drivers/mmc/host/rtsx_usb_sdmmc.c | 31
> > > ++++++++++++++++++++-----------
> > > 1 file changed, 20 insertions(+), 11 deletions(-)
> > >
> > > --
> > > 2.43.0
> > >
> >
> > Ricky, I would appreciate your feedback on these too. Or at least an ack.
>
> Hi Ulf,
> Sorry, I forgot to reply this patch,
> This patch is fine for me, and this also work well Thank you
>
Acked-by: Ricky Wu <ricky_wu@realtek.com>
>
> >
> > Kind regards
> > Uffe
next prev parent reply other threads:[~2025-06-19 2:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 11:16 [PATCH 0/4] mmc: rtsx_usb_sdmmc: Improve sd_set_power_mode() Ulf Hansson
2025-06-10 11:16 ` [PATCH 1/4] mmc: rtsx_usb_sdmmc: Fix error-path in sd_set_power_mode() Ulf Hansson
2025-06-10 11:16 ` [PATCH 2/4] mmc: rtsx_usb_sdmmc: Print debug-messages at power-on/off errors Ulf Hansson
2025-06-10 11:16 ` [PATCH 3/4] mmc: rtsx_usb_sdmmc: Convert sd_set_power_mode() into void Ulf Hansson
2025-06-10 11:16 ` [PATCH 4/4] mmc: rtsx_usb_sdmmc: Re-work the code in sd_set_power_mode() Ulf Hansson
2025-06-10 11:40 ` [PATCH 0/4] mmc: rtsx_usb_sdmmc: Improve sd_set_power_mode() Avri Altman
2025-06-17 13:56 ` Ulf Hansson
2025-06-18 2:48 ` Ricky WU
2025-06-19 2:27 ` Ricky WU [this message]
2025-06-19 11:20 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4273aceac8104c6a95bcf94be2a6e567@realtek.com \
--to=ricky_wu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox