From: Viresh Kumar <viresh.kumar@st.com>
To: vinod.koul@intel.com, dan.j.williams@intel.com
Cc: cjb@laptop.org, rmk+kernel@arm.linux.org.uk,
linus.walleij@linaro.org, ulf.hansson@stericsson.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
egtvedt@samfundet.no, hskinnemoen@gmail.com,
kernel@pengutronix.de, perex@perex.cz,
linux-arm-kernel@lists.infradead.org, armando.visconti@st.com,
shiraz.hashim@st.com, vipin.kumar@st.com,
rajeev-dlh.kumar@st.com, deepak.sikri@st.com,
vipulkumar.samar@st.com, amit.virdi@st.com, viresh.kumar@st.com,
pratyush.anand@st.com, bhupesh.sharma@st.com,
viresh.linux@gmail.com, bhavna.yadav@st.com,
vincenzo.frascino@st.com, mirko.gardi@st.com
Subject: [PATCH V3 05/12] dmaengine/dw_dmac: Don't use magic number for total number of channels
Date: Wed, 1 Feb 2012 16:12:21 +0530 [thread overview]
Message-ID: <42b0936c114afb25ae50b34ecd3302ef86ea4190.1328091915.git.viresh.kumar@st.com> (raw)
In-Reply-To: <cover.1328091915.git.viresh.kumar@st.com>
Total number of channels is passed in pdata->nr_channels variable, thus we must
not use magic number '7' for total number of channels.
Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
drivers/dma/dw_dmac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 3a3d7ed..1577394 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -1432,7 +1432,7 @@ static int __init dw_probe(struct platform_device *pdev)
/* 7 is highest priority & 0 is lowest. */
if (pdata->chan_priority == CHAN_PRIORITY_ASCENDING)
- dwc->priority = 7 - i;
+ dwc->priority = pdata->nr_channels - i - 1;
else
dwc->priority = i;
--
1.7.8.110.g4cb5d
next prev parent reply other threads:[~2012-02-01 10:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 10:42 [PATCH V3 00/12] dmaengine: Pl08x and dw_dmac updates Viresh Kumar
2012-02-01 10:42 ` [PATCH V3 01/12] dmaengine/dw_dmac: Hibernation support in dw_dmac Viresh Kumar
2012-02-01 10:42 ` [PATCH V3 02/12] dmaengine: Add flow controller information to dma_slave_config Viresh Kumar
2012-02-01 10:42 ` [PATCH V3 03/12] dmaengine: Pass dma_slave_config .device_fc = NULL for all existing users Viresh Kumar
2012-02-01 10:42 ` [PATCH V3 04/12] dmaengine/amba-pl08x: Take flow controller info from DMA_SLAVE_CONFIG Viresh Kumar
2012-02-01 10:42 ` Viresh Kumar [this message]
2012-02-01 10:42 ` [PATCH V3 06/12] dmaengine/dw_dmac: Use dev_get_platdata() instead of accessing dev directly Viresh Kumar
2012-02-01 10:42 ` [PATCH V3 07/12] dmaengine/dw_dmac: Don't handle block interrupts Viresh Kumar
2012-02-01 10:42 ` [PATCH V3 08/12] dmaengine/dw_dmac: Unmap all memory buffers after completion of non-slave transfers Viresh Kumar
2012-02-02 12:15 ` Russell King - ARM Linux
2012-02-06 8:11 ` Viresh Kumar
2012-02-01 10:42 ` [PATCH V3 09/12] dmaengine/dw_dmac: Add 64 bit access width support for slave xfers on mem side Viresh Kumar
2012-02-01 10:42 ` [PATCH V3 10/12] dmaengine/dw_dmac: Add support for DMA_SLAVE_CONFIG Viresh Kumar
2012-02-01 10:42 ` [PATCH V3 11/12] dmaengine/dw_dmac: Fix dw_dmac user drivers to adapt to slave_config changes Viresh Kumar
2012-02-01 10:42 ` [PATCH V3 12/12] dmaengine/dw_dmac: Remove unused fields in struct dw_dma_slave Viresh Kumar
2012-02-22 12:51 ` [PATCH V3 00/12] dmaengine: Pl08x and dw_dmac updates Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42b0936c114afb25ae50b34ecd3302ef86ea4190.1328091915.git.viresh.kumar@st.com \
--to=viresh.kumar@st.com \
--cc=amit.virdi@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=cjb@laptop.org \
--cc=dan.j.williams@intel.com \
--cc=deepak.sikri@st.com \
--cc=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mirko.gardi@st.com \
--cc=perex@perex.cz \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=shiraz.hashim@st.com \
--cc=ulf.hansson@stericsson.com \
--cc=vincenzo.frascino@st.com \
--cc=vinod.koul@intel.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).