Re: [PATCH 8/9] mmc: sh_mobile_sdhi: remove .init/.cleanup

Geert Uytterhoeven
2015-01-05T09:02:04Z

Hi Morimoto-san,

On Mon, Jan 5, 2015 at 8:03 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> No one is using .init/.cleanup callback function.
> Let's remove these.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> drivers/mmc/host/sh_mobile_sdhi.c | 26 +-------------------------
> include/linux/mmc/sh_mobile_sdhi.h | 15 ---------------
> 2 files changed, 1 insertion(+), 40 deletions(-)
>
> diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
> index f8268b7..eae229f 100644
> --- a/drivers/mmc/host/sh_mobile_sdhi.c
> +++ b/drivers/mmc/host/sh_mobile_sdhi.c
> @@ -156,15 +156,6 @@ static int sh_mobile_sdhi_multi_io_quirk(struct mmc_card *card,
> return blk_size;
> }
>
> -static void sh_mobile_sdhi_cd_wakeup(const struct platform_device *pdev)
> -{
> - mmc_detect_change(platform_get_drvdata(pdev), msecs_to_jiffies(100));
> -}
> -
> -static const struct sh_mobile_sdhi_ops sdhi_ops = {
> - .cd_wakeup = sh_mobile_sdhi_cd_wakeup,
> -};
> -

Is this intentional?

While .cd_wakeup looks indeed unused, you forgot to mention its removal in
the patch description.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds