Re: [PATCH 8/9] mmc: sh_mobile_sdhi: remove .init/.cleanup

Kuninori Morimoto
2015-01-05T09:15:34Z

Hi Geert

Thank you for your review.

> > -static void sh_mobile_sdhi_cd_wakeup(const struct platform_device *pdev)
> > -{
> > - mmc_detect_change(platform_get_drvdata(pdev), msecs_to_jiffies(100));
> > -}
> > -
> > -static const struct sh_mobile_sdhi_ops sdhi_ops = {
> > - .cd_wakeup = sh_mobile_sdhi_cd_wakeup,
> > -};
> > -
>
> Is this intentional?
>
> While .cd_wakeup looks indeed unused, you forgot to mention its removal in
> the patch description.

Because, sdhi_ops (and .cd_wakeup) is used from .init
OK, I will explain about it in patch description in v2
Thanks

Best regards
---
Kuninori Morimoto