From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>,
linux-samsung-soc@vger.kernel.org, grundler@chromium.org,
t.figa@samsung.com, linux-mmc@vger.kernel.org, joshi@samsung.com,
dianders@chromium.org, jh80.chung@samsung.com,
tgih.jun@samsung.com, kgene.kim@samsung.com, cjb@laptop.org,
Sonny Rao <sonnyrao@chromium.org>
Subject: Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure
Date: Tue, 13 May 2014 10:46:52 +0200 [thread overview]
Message-ID: <4576681.G7gtKHPGQn@wuerfel> (raw)
In-Reply-To: <1399945121-7387-1-git-send-email-sonnyrao@chromium.org>
On Monday 12 May 2014 18:38:41 Sonny Rao wrote:
> +#ifndef CONFIG_MMC_DW_IDMAC
> + if (host->use_dma)
> + flags |= SDMMC_CTRL_DMA_RESET;
> +#endif
Can you change the above like this?
if (IS_ENABLED(CONFIG_MMC_DW_IDMAC) && host->use_dma)
flags |= SDMMC_CTRL_DMA_RESET;
That is generally considered the preferred style these days.
Arnd
prev parent reply other threads:[~2014-05-13 8:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 1:38 [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure Sonny Rao
2014-05-13 5:02 ` Seungwon Jeon
2014-05-13 7:16 ` Sonny Rao
2014-05-13 11:09 ` Seungwon Jeon
2014-05-17 0:36 ` Sonny Rao
2014-05-20 1:49 ` Seungwon Jeon
2014-05-22 18:54 ` Sonny Rao
2014-05-29 0:35 ` [PATCH] " Sonny Rao
2014-05-29 5:17 ` Jaehoon Chung
2014-06-09 21:35 ` Sonny Rao
2014-06-09 22:00 ` Sonny Rao
2014-07-10 12:28 ` Seungwon Jeon
2014-07-10 22:35 ` Sonny Rao
2014-07-11 10:20 ` Seungwon Jeon
2014-07-11 19:48 ` Sonny Rao
2014-07-11 20:53 ` [PATCHv5] " Sonny Rao
2014-07-14 5:52 ` Jaehoon Chung
2014-07-14 22:06 ` [PATCHv6] " Sonny Rao
2014-07-18 13:37 ` Seungwon Jeon
2014-07-26 9:55 ` Ulf Hansson
2014-05-13 5:19 ` [PATCHv2] " Kukjin Kim
2014-05-13 8:46 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4576681.G7gtKHPGQn@wuerfel \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=dianders@chromium.org \
--cc=grundler@chromium.org \
--cc=jh80.chung@samsung.com \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sonnyrao@chromium.org \
--cc=t.figa@samsung.com \
--cc=tgih.jun@samsung.com \
--cc=yuvaraj.cd@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox