From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. Date: Wed, 06 May 2015 09:31:42 +0200 Message-ID: <4635229.bceBxngCoe@wuerfel> References: <1430817426-5241-1-git-send-email-stripathi@apm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([212.227.126.130]:56999 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbbEFHcI (ORCPT ); Wed, 6 May 2015 03:32:08 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Suman Tripathi Cc: Rob Herring , "chris@printf.net" , Anton Vorontsov , Michal Simek , "linux-mmc@vger.kernel.org" , linuxppc-dev , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Don Dutile , "jcm@redhat.com" , Mark Langsdorf , "patches@apm.com" On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote: > >> @@ -533,6 +567,16 @@ > >> interrupts = <0x0 0x4f 0x4>; > >> }; > >> > >> + sdhc0: sdhc@1c000000 { > >> + device_type = "sdhc"; > > > > device_type generally should not be used (there are a few exceptions). > > Okay !! > While we're at it, please change sdhc@1c000000 to mmc@1c000000. Even though Linux does not care, we try to use the standard device names for consistency. Arnd