From: Adrian Hunter <adrian.hunter@intel.com>
To: Haibo Chen <haibo.chen@nxp.com>,
ulf.hansson@linaro.org, aisheng.dong@nxp.com
Cc: tharvey@gateworks.com, stable@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: increase the pad I/O drive strength for DDR50 card
Date: Tue, 18 Apr 2017 10:01:15 +0300 [thread overview]
Message-ID: <46db055c-73b8-5aa0-cc33-021d528ee816@intel.com> (raw)
In-Reply-To: <1492427402-5506-1-git-send-email-haibo.chen@nxp.com>
On 17/04/17 14:10, Haibo Chen wrote:
> Currently for DDR50 card, it need tuning in default. We meet tuning fail
> issue for DDR50 card and some data CRC error when DDR50 sd card works.
>
> This is because the default pad I/O drive strength can't make sure DDR50
> card work stable. So increase the pad I/O drive strength for DDR50 card,
> and use pins_100mhz.
>
> Tested-and-reported-by: Tim Harvey <tharvey@gateworks.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Cc: stable@vger.kernel.org # v4.4+
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index cf666a0..abad67a 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -830,6 +830,7 @@ static int esdhc_change_pinstate(struct sdhci_host *host,
>
> switch (uhs) {
> case MMC_TIMING_UHS_SDR50:
> + case MMC_TIMING_UHS_DDR50:
> pinctrl = imx_data->pins_100mhz;
> break;
> case MMC_TIMING_UHS_SDR104:
>
next prev parent reply other threads:[~2017-04-18 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 11:10 [PATCH] mmc: sdhci-esdhc-imx: increase the pad I/O drive strength for DDR50 card Haibo Chen
2017-04-18 7:01 ` Adrian Hunter [this message]
2017-04-18 10:23 ` Dong Aisheng
2017-04-18 14:33 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46db055c-73b8-5aa0-cc33-021d528ee816@intel.com \
--to=adrian.hunter@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=haibo.chen@nxp.com \
--cc=linux-mmc@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox