Re: [PATCH v5] mmc: sdhci_am654: Add SDHCI_QUIRK2_SUPPRESS_V1P8_ENA quirk to am62 compatible

[Judith Mendez <jm@ti.com>]

Hi Adrian,

On 5/14/25 4:10 AM, Adrian Hunter wrote:
> On 14/05/2025 03:25, Judith Mendez wrote:
>> Add a new struct for platform data for the ti,am62-sdhci compatible to
>> apply additional quirks, namely "SDHCI_QUIRK2_SUPPRESS_V1P8_ENA", to
>> host controllers with am62 compatible.
> 
> Could add:
> 
> Note, the fix was originally introduced by commit 941a7abd4666
> ("mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch") but was
> found to be applied too broadly and had to be reverted.

Sure I can add for v6

...

>>   
>> +static const struct sdhci_pltfm_data sdhci_am62_4bit_pdata = {
>> +	.ops = &sdhci_j721e_4bit_ops,
>> +	.quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
>> +	.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
>> +};
> 
> sdhci_am62_4bit_pdata is the same as sdhci_j721e_4bit_pdata

oh right sdhci_am62_4bit_pdata can be removed. thanks. will fix for v6

Judith

> 
>> +
>> +static const struct sdhci_am654_driver_data sdhci_am62_4bit_drvdata = {
>> +	.pdata = &sdhci_am62_4bit_pdata,
>> +	.flags = IOMUX_PRESENT,
>> +	.quirks = SDHCI_AM654_QUIRK_SUPPRESS_V1P8_ENA,
>> +};
>> +

...