From: Jingoo Han <jg1.han@samsung.com>
To: Laurent Navet <laurent.navet@gmail.com>,
"cjb@laptop.org" <cjb@laptop.org>
Cc: "nico@fluxnic.net" <nico@fluxnic.net>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"thomas.petazzoni@free-electrons.com"
<thomas.petazzoni@free-electrons.com>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
Jingoo Han <jg1.han@samsung.com>,
"sachin.kamat@linaro.org" <sachin.kamat@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] drivers: mmc: host: use devm_ioremap_resource()
Date: Thu, 16 May 2013 08:19:51 +0000 (GMT) [thread overview]
Message-ID: <4876879.136041368692387848.JavaMail.weblogic@epml12> (raw)
Thursday, May 16, 2013 5:22 PM, Laurent Navet wrote:
>
> Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
>
> Found with coccicheck and this semantic patch:
> scripts/coccinelle/api/devm_ioremap_resource.cocci
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com
Best regards,
Jingoo Han
> ---
> drivers/mmc/host/mvsdio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
> index 8960fc8..a66ee4b 100644
> --- a/drivers/mmc/host/mvsdio.c
> +++ b/drivers/mmc/host/mvsdio.c
> @@ -758,9 +758,9 @@ static int __init mvsd_probe(struct platform_device *pdev)
>
> spin_lock_init(&host->lock);
>
> - host->base = devm_request_and_ioremap(&pdev->dev, r);
> - if (!host->base) {
> - ret = -ENOMEM;
> + host->base = devm_ioremap_resource(&pdev->dev, r);
> + if (IS_ERR(host->base)) {
> + ret = PTR_ERR(host->base);
> goto out;
> }
>
> --
> 1.7.10.4
next reply other threads:[~2013-05-16 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 8:19 Jingoo Han [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-16 8:22 [PATCH V2] drivers: mmc: host: use devm_ioremap_resource() Laurent Navet
2013-05-16 8:22 ` Laurent Navet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4876879.136041368692387848.JavaMail.weblogic@epml12 \
--to=jg1.han@samsung.com \
--cc=andrew@lunn.ch \
--cc=cjb@laptop.org \
--cc=jason@lakedaemon.net \
--cc=laurent.navet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=sachin.kamat@linaro.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).