* Re: [PATCH V2] drivers: mmc: host: use devm_ioremap_resource()
@ 2013-05-16 8:19 Jingoo Han
0 siblings, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2013-05-16 8:19 UTC (permalink / raw)
To: Laurent Navet, cjb@laptop.org
Cc: nico@fluxnic.net, andrew@lunn.ch,
thomas.petazzoni@free-electrons.com, jason@lakedaemon.net,
Jingoo Han, sachin.kamat@linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Thursday, May 16, 2013 5:22 PM, Laurent Navet wrote:
>
> Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
>
> Found with coccicheck and this semantic patch:
> scripts/coccinelle/api/devm_ioremap_resource.cocci
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com
Best regards,
Jingoo Han
> ---
> drivers/mmc/host/mvsdio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
> index 8960fc8..a66ee4b 100644
> --- a/drivers/mmc/host/mvsdio.c
> +++ b/drivers/mmc/host/mvsdio.c
> @@ -758,9 +758,9 @@ static int __init mvsd_probe(struct platform_device *pdev)
>
> spin_lock_init(&host->lock);
>
> - host->base = devm_request_and_ioremap(&pdev->dev, r);
> - if (!host->base) {
> - ret = -ENOMEM;
> + host->base = devm_ioremap_resource(&pdev->dev, r);
> + if (IS_ERR(host->base)) {
> + ret = PTR_ERR(host->base);
> goto out;
> }
>
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH V2] drivers: mmc: host: use devm_ioremap_resource()
@ 2013-05-16 8:22 Laurent Navet
2013-05-16 8:22 ` Laurent Navet
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Navet @ 2013-05-16 8:22 UTC (permalink / raw)
To: nico, cjb
Cc: andrew, thomas.petazzoni, jason, jg1.han, sachin.kamat, linux-mmc,
linux-kernel
This second version fix a typo in commit message reported by Jingoo Han
Regards,
Laurent.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH V2] drivers: mmc: host: use devm_ioremap_resource()
2013-05-16 8:22 Laurent Navet
@ 2013-05-16 8:22 ` Laurent Navet
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Navet @ 2013-05-16 8:22 UTC (permalink / raw)
To: nico, cjb
Cc: andrew, thomas.petazzoni, jason, jg1.han, sachin.kamat, linux-mmc,
linux-kernel, Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/mmc/host/mvsdio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
index 8960fc8..a66ee4b 100644
--- a/drivers/mmc/host/mvsdio.c
+++ b/drivers/mmc/host/mvsdio.c
@@ -758,9 +758,9 @@ static int __init mvsd_probe(struct platform_device *pdev)
spin_lock_init(&host->lock);
- host->base = devm_request_and_ioremap(&pdev->dev, r);
- if (!host->base) {
- ret = -ENOMEM;
+ host->base = devm_ioremap_resource(&pdev->dev, r);
+ if (IS_ERR(host->base)) {
+ ret = PTR_ERR(host->base);
goto out;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-16 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-16 8:19 [PATCH V2] drivers: mmc: host: use devm_ioremap_resource() Jingoo Han
-- strict thread matches above, loose matches on Subject: below --
2013-05-16 8:22 Laurent Navet
2013-05-16 8:22 ` Laurent Navet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).