From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-kernel@lists.codethink.co.uk, linux-mmc@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH] [V3] mmc: mmci: add missing include of mmci_qcom_dml.h
Date: Fri, 17 Jun 2016 13:41:19 +0200 [thread overview]
Message-ID: <4881149.p2gsOpsjH3@wuerfel> (raw)
In-Reply-To: <1466102852-10063-1-git-send-email-ben.dooks@codethink.co.uk>
On Thursday, June 16, 2016 7:47:32 PM CEST Ben Dooks wrote:
> Note, since this is a very small addition to the mmci
> module, it would better to build it into the main mmci
> driver (either by direct copy, or multiple linked
> module)
I suspect the latter is actually what the author intended,
except they accidentally made the symbol tristate and got the
Makefile logic wrong.
Most likely, the qcom developers never considered the case
of having loadable modules.
Arnd
prev parent reply other threads:[~2016-06-17 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 18:47 [PATCH] [V3] mmc: mmci: add missing include of mmci_qcom_dml.h Ben Dooks
2016-06-16 18:50 ` Ben Dooks
2016-06-17 8:08 ` Srinivas Kandagatla
2016-06-17 11:41 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4881149.p2gsOpsjH3@wuerfel \
--to=arnd@arndb.de \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox