From: Adrian Hunter <adrian.hunter@intel.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload
Date: Fri, 21 Oct 2016 10:23:29 +0300 [thread overview]
Message-ID: <488cd9f4-1522-6346-6618-0f3168badf96@intel.com> (raw)
In-Reply-To: <20161021064819.4y5jrdetrqsvibfa@rfolt0960.corp.atmel.com>
On 21/10/16 09:48, Ludovic Desroches wrote:
> On Mon, Oct 17, 2016 at 01:13:45PM -0300, Javier Martinez Canillas wrote:
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
>> $
>>
>> After this patch:
>>
>> $ modinfo drivers/mmc/host/sdhci-of-at91.ko | grep alias
>> alias: of:N*T*Catmel,sama5d2-sdhciC*
>> alias: of:N*T*Catmel,sama5d2-sdhci
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Thanks
>> ---
>>
>> drivers/mmc/host/sdhci-of-at91.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
>> index a9b7fc06c434..2f9ad213377a 100644
>> --- a/drivers/mmc/host/sdhci-of-at91.c
>> +++ b/drivers/mmc/host/sdhci-of-at91.c
>> @@ -100,6 +100,7 @@ static const struct of_device_id sdhci_at91_dt_match[] = {
>> { .compatible = "atmel,sama5d2-sdhci", .data = &soc_data_sama5d2 },
>> {}
>> };
>> +MODULE_DEVICE_TABLE(of, sdhci_at91_dt_match);
>>
>> #ifdef CONFIG_PM
>> static int sdhci_at91_runtime_suspend(struct device *dev)
>> --
>> 2.7.4
>>
>
next prev parent reply other threads:[~2016-10-21 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 16:13 [PATCH 1/2] mmc: mediatek: Fix module autoload Javier Martinez Canillas
2016-10-17 16:13 ` [PATCH 2/2] mmc: sdhci-of-at91: " Javier Martinez Canillas
2016-10-21 6:48 ` Ludovic Desroches
2016-10-21 7:23 ` Adrian Hunter [this message]
2016-10-21 8:21 ` Ulf Hansson
2016-10-21 8:22 ` [PATCH 1/2] mmc: mediatek: " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488cd9f4-1522-6346-6618-0f3168badf96@intel.com \
--to=adrian.hunter@intel.com \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox