From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C614C61DA4 for ; Thu, 16 Feb 2023 09:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbjBPJSs (ORCPT ); Thu, 16 Feb 2023 04:18:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjBPJSr (ORCPT ); Thu, 16 Feb 2023 04:18:47 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7286CC29 for ; Thu, 16 Feb 2023 01:18:46 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id jg8so3585669ejc.6 for ; Thu, 16 Feb 2023 01:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ns1a+ziaB8qV7FyQY4+Sg+p/ozjebr/JvYh0uNJdX9o=; b=u/Lq1gVCJq3B7Gfy6sHmh4krfi2milAhoL6bOlH9pZ3zE0WgtGD8cmqwxElFqWrfIx ft3ohfCunwzcMvZ4xTt83sKdfn+HczozJ78KCjDmMd3F4niudCDVhfvs8kRLrtqWWYtd ysecBjmsMZ+5h6C1PzTdOPPyZgGitRhFr06TZbc0afULUcy1h7aHRywginrTKKTbRVST KX25neCOx45VG93ehWDh3NsoOzWONzpqFafC98CjUw3F2UL/zO1dYIU4+AIlnIceAsk5 dgiQei1lglvBNZR1/ufp6jMXoeKw/JVRMMp0/UDuS4/YJNn0jtqmgwUgwN8TKZd8kD0V pjUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ns1a+ziaB8qV7FyQY4+Sg+p/ozjebr/JvYh0uNJdX9o=; b=k8an3fPCoLwD3i89Cn1zAJnXtd/lXyzPAO+oaUWFGL+Z7BSDJSR37keGLgMV6dLuJc +9tMp7KL1jcG4S8R5keiCvJ6NcZZj8hRERcyLBRio7nu/2nDFwcPRoADXEqyObTC3Fgw 3PRYCZ9Y0JfUfG/Yr9anBttqY/ogqxbBpqSx5W6Ath/cuE49x2XGuP5HmTE0xejtZuXe TiReH1AQXrYL9NzGG2gewArOKqxBA5t1PnNqdwPe4CYZNFfaSUBrmPAVxVqQWTnci7Ti zBCsAB6kzCQdULGEemB14eyNUz15mfL2ePkM53lOr5JIjtd0tJEJv5OQ1T96zTCRhNHT XwCA== X-Gm-Message-State: AO0yUKXjjQ8MbnuOvu+WB2JPy9Krvs4wz5zCegBxZvwoEu7uXcHryr9R /lSc7ydAd2/nN9Cm7Z4M4NR4aA== X-Google-Smtp-Source: AK7set82c1wAvrDeb+UgjwQtg0XXg8DkrihCvBsVMrF9Z23BPbCFbBNgEEveMlwyyH02uoUFmIbcAA== X-Received: by 2002:a17:907:3c26:b0:8aa:9841:5e29 with SMTP id gh38-20020a1709073c2600b008aa98415e29mr5012129ejc.77.1676539125143; Thu, 16 Feb 2023 01:18:45 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id q11-20020a17090622cb00b008b1569b37edsm538241eja.214.2023.02.16.01.18.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 01:18:44 -0800 (PST) Message-ID: <48b4a87a-c5e9-c3ec-2492-bb2afb495398@linaro.org> Date: Thu, 16 Feb 2023 10:18:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 0/3] mmc: support setting card detect interrupt from drivers and use it in meson-gx Content-Language: en-US To: Ulf Hansson , Heiner Kallweit Cc: Rob Herring , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." , "devicetree@vger.kernel.org" References: <15df9ef0-9b73-ca5a-d3cf-0585cd135bc5@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 15/02/2023 13:48, Ulf Hansson wrote: > On Tue, 14 Feb 2023 at 22:39, Heiner Kallweit wrote: >> >> On certain platforms like Amlogic Meson gpiod_to_irq() isn't supported >> due to the design of gpio / interrupt controller. Therefore provide an >> option for drivers to pass the card detect interrupt number >> (retrieved e.g. from device tree) to mmc core. >> >> v2: >> - use another mechanism for passing and storing the cd interrupt >> - add patch 2 >> >> Heiner Kallweit (3): >> mmc: core: support setting card detect interrupt from drivers >> dt-bindings: mmc: meson-gx: support specifying cd interrupt >> mmc: meson-gx: support platform interrupt as card detect interrupt >> >> .../bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +- >> drivers/mmc/core/slot-gpio.c | 17 ++++++++++++++++- >> drivers/mmc/host/meson-gx-mmc.c | 5 ++++- >> include/linux/mmc/slot-gpio.h | 1 + >> 4 files changed, 22 insertions(+), 3 deletions(-) >> > > Applied for next, thanks! A bit too fast. Binding is incorrect - suggests ABI break and makes interrupts not described enough. Best regards, Krzysztof