From: Arnd Bergmann <arnd@arndb.de>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
cjb@laptop.org, gdjakov@mm-sol.com
Subject: Re: [PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators
Date: Mon, 07 Apr 2014 14:51:41 +0200 [thread overview]
Message-ID: <4902841.krZFXFDZqb@wuerfel> (raw)
In-Reply-To: <53429AD4.7030508@topic.nl>
On Monday 07 April 2014 14:32:20 Mike Looijmans wrote:
> On 04/07/2014 02:25 PM, Arnd Bergmann wrote:
>
> Judging from the kernel output, regulator_get_optional returns -ENODEV if the
> supply wasn't found.
>
> Maybe the API is confusing (or wrong?) here.
>
> If you change the code as per your suggestion, the SD will not work unless you
> explicitly assign supplies. And judging from what I've seen so far, I am the
> first to have ever attached a power supply to this controller...
It's certainly not very "optional" if it returns an error here.
You could try to special-case the "-ENODEV" return here, but I think it
would be better to change the regulator interface to be less confusing.
Arnd
next prev parent reply other threads:[~2014-04-07 12:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 14:18 [PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators Mike Looijmans
2014-03-26 15:09 ` Georgi Djakov
2014-03-27 17:47 ` Mike Looijmans
2014-03-27 21:13 ` Georgi Djakov
2014-03-28 7:30 ` Mike Looijmans
2014-03-28 10:20 ` Ulf Hansson
2014-04-07 6:38 ` Mike Looijmans
2014-04-07 6:45 ` Mike Looijmans
2014-04-07 8:11 ` Arnd Bergmann
2014-04-07 12:09 ` Mike Looijmans
2014-04-07 12:16 ` Ben Dooks
2014-04-07 12:18 ` Ben Dooks
2014-04-07 12:25 ` Arnd Bergmann
2014-04-07 12:32 ` Mike Looijmans
2014-04-07 12:51 ` Arnd Bergmann [this message]
2014-04-07 13:11 ` Mike Looijmans
2014-04-16 20:15 ` Andrew Bresticker
2014-04-16 20:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4902841.krZFXFDZqb@wuerfel \
--to=arnd@arndb.de \
--cc=ben.dooks@codethink.co.uk \
--cc=cjb@laptop.org \
--cc=gdjakov@mm-sol.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).