Re: [PATCH] sdio: add MMC_CAP_VDD_165_195 host capability

Andrew Morton
2009-09-28T22:59:26Z

On Mon, 28 Sep 2009 19:10:48 +0100
Matt Fleming <matt@console-pimps.org> wrote:

> >
> > + if ((ocr & MMC_VDD_165_195) && !(host->caps & MMC_CAP_VDD_165_195)) {
> > + printk(KERN_WARNING "%s: SDIO card claims to support the "
> > + "incompletely defined 'low voltage range'. This "
> > + "will be ignored.\n", mmc_hostname(host));
> > + ocr &= ~MMC_VDD_165_195;
> > + }
> > +
> > host->ocr = mmc_select_voltage(host, ocr);
> >
> > /*
>
>
> I know you copied this warning from the old code

It'd be better to avoid copying anything at all. Are we missing
code-sharing opportunities here?

> but does anyone think
> it's worth making this warning a bit clearer? e.g,
>
> > + printk(KERN_WARNING "%s: SDIO card claims to support the "
> > + "incompletely defined 'low voltage range', but the "
> > + "host controller does not. This voltage range"
> > + "will be ignored.\n", mmc_hostname(host));

That looks better to me.