Re: [PATCH] sdio: add MMC_CAP_VDD_165_195 host capability

Matt Fleming
2009-09-29T05:53:57Z

On Mon, Sep 28, 2009 at 03:59:00PM -0700, Andrew Morton wrote:
> On Mon, 28 Sep 2009 19:10:48 +0100
> Matt Fleming <matt@console-pimps.org> wrote:
>
> > >
> > > + if ((ocr & MMC_VDD_165_195) && !(host->caps & MMC_CAP_VDD_165_195)) {
> > > + printk(KERN_WARNING "%s: SDIO card claims to support the "
> > > + "incompletely defined 'low voltage range'. This "
> > > + "will be ignored.\n", mmc_hostname(host));
> > > + ocr &= ~MMC_VDD_165_195;
> > > + }
> > > +
> > > host->ocr = mmc_select_voltage(host, ocr);
> > >
> > > /*
> >
> >
> > I know you copied this warning from the old code
>
> It'd be better to avoid copying anything at all. Are we missing
> code-sharing opportunities here?
>

No, Ohad's commit 27cce39f555def6f5ebe7f03d69ccc44ab25f0b2 "sdio: do not
ignore MMC_VDD_165_195" deleted this warning and this commit is just
bringing it back from the dead.

It seems that Philip and David have other ideas on how they want to
handle this voltage range so this patch probably doesn't need picking
up.