From: David Vrabel <david.vrabel@csr.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend
Date: Wed, 10 Feb 2010 11:30:55 +0000 [thread overview]
Message-ID: <4B7298EF.4070604@csr.com> (raw)
In-Reply-To: <1265747366-6676-6-git-send-email-nico@fluxnic.net>
Nicolas Pitre wrote:
> From: Daniel Drake <dsd@laptop.org>
>
> And bring them back to 4-bit mode during resume.
Why? Is this for a specific card that doesn't support asynchronous card
interrupts while in 4-bit mode? If so, I'd suggest a card quirk for
this and only switch modes for these cards.
> + ctrl |= SDIO_BUS_ASYNC_INT;
This bit is for SPI mode only. Why are you setting it here?
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
next prev parent reply other threads:[~2010-02-10 11:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 20:29 [PATCH 0/5] SDIO support for "powered" suspend Nicolas Pitre
2010-02-09 20:29 ` [PATCH 1/5] SDIO: introduce API for special power management features Nicolas Pitre
2010-02-11 20:32 ` Andrew Morton
2010-02-11 20:57 ` Nicolas Pitre
2010-02-09 20:29 ` [PATCH 2/5] SDIO: sdhci support for suspend mode PM features Nicolas Pitre
2010-02-09 20:29 ` [PATCH 3/5] SDIO: Don't use CMD[357] as part of a powered SDIO resume Nicolas Pitre
2010-02-09 20:29 ` [PATCH 4/5] SDIO: kick the interrupt thread upon a resume Nicolas Pitre
2010-02-09 20:29 ` [PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend Nicolas Pitre
2010-02-10 11:30 ` David Vrabel [this message]
2010-02-10 15:17 ` Chris Ball
2010-02-10 16:03 ` David Vrabel
2010-02-10 16:32 ` Chris Ball
2010-02-10 16:49 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7298EF.4070604@csr.com \
--to=david.vrabel@csr.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox