From: David Vrabel <david.vrabel@csr.com>
To: Chris Ball <cjb@laptop.org>
Cc: Nicolas Pitre <nico@fluxnic.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend
Date: Wed, 10 Feb 2010 16:03:24 +0000 [thread overview]
Message-ID: <4B72D8CC.9030605@csr.com> (raw)
In-Reply-To: <m38wb115nk.fsf@pullcord.laptop.org>
Chris Ball wrote:
> Hi David,
>
> > Why? Is this for a specific card that doesn't support
> > asynchronous card interrupts while in 4-bit mode? If so, I'd
> > suggest a card quirk for this and only switch modes for these
> > cards.
>
> (As a check that we're on the same page -- sdio_disable_wide() is only
> called if MMC_PM_KEEP_POWER is true, which means the system is going
> to be suspended but the card will remain externally powered without
> its clock.)
>
> Under the circumstances above, it's a requirement of the SDIO spec
> that moving to 1-bit mode must happen before stopping the clock if
> the interrupt mechanism is to be used to wake the host, and the
> chipset we've been using (Via VX855) fails to generate a wakeup if
> the switch isn't made. Do you have experience of another chipset
> that doesn't need the switch to 1-bit mode for a clockless wakeup?
I couldn't find anything in the SDIO specification (you know the section
number?). Part A2 has a requirement that the controller be placed into
1-bit mode but this doesn't mean that the card has to be.
Maybe it's not really a big deal, a single command only costs a few 10s
of microseconds anyway.
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
next prev parent reply other threads:[~2010-02-10 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 20:29 [PATCH 0/5] SDIO support for "powered" suspend Nicolas Pitre
2010-02-09 20:29 ` [PATCH 1/5] SDIO: introduce API for special power management features Nicolas Pitre
2010-02-11 20:32 ` Andrew Morton
2010-02-11 20:57 ` Nicolas Pitre
2010-02-09 20:29 ` [PATCH 2/5] SDIO: sdhci support for suspend mode PM features Nicolas Pitre
2010-02-09 20:29 ` [PATCH 3/5] SDIO: Don't use CMD[357] as part of a powered SDIO resume Nicolas Pitre
2010-02-09 20:29 ` [PATCH 4/5] SDIO: kick the interrupt thread upon a resume Nicolas Pitre
2010-02-09 20:29 ` [PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend Nicolas Pitre
2010-02-10 11:30 ` David Vrabel
2010-02-10 15:17 ` Chris Ball
2010-02-10 16:03 ` David Vrabel [this message]
2010-02-10 16:32 ` Chris Ball
2010-02-10 16:49 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B72D8CC.9030605@csr.com \
--to=david.vrabel@csr.com \
--cc=akpm@linux-foundation.org \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox