RE: [PATCH v8 2/2] omap hsmmc: adaptation of sdma descriptor autoloading feature

Madhusudhan
2010-05-06T16:20:17Z

> -----Original Message-----
> From: Shilimkar, Santosh [mailto:santosh.shilimkar@ti.com]
> Sent: Thursday, May 06, 2010 4:39 AM
> To: kishore kadiyala
> Cc: S, Venkatraman; linux-omap@vger.kernel.org; linux-mmc@vger.kernel.org;
> linux-arm-kernel@lists.arm.linux.org.uk; Chikkature Rajashekar,
> Madhusudhan; Adrian Hunter; Kadiyala, Kishore; Tony Lindgren
> Subject: RE: [PATCH v8 2/2] omap hsmmc: adaptation of sdma descriptor
> autoloading feature
>
> > -----Original Message-----
> > From: kishore kadiyala [mailto:kishorek.kadiyala@gmail.com]
> > Sent: Thursday, May 06, 2010 2:32 PM
> > To: Shilimkar, Santosh
> > Cc: S, Venkatraman; linux-omap@vger.kernel.org; linux-
> mmc@vger.kernel.org; linux-arm-
> > kernel@lists.arm.linux.org.uk; Chikkature Rajashekar, Madhusudhan;
> Adrian Hunter; Kadiyala, Kishore;
> > Tony Lindgren
> > Subject: Re: [PATCH v8 2/2] omap hsmmc: adaptation of sdma descriptor
> autoloading feature
> >
> > <<snip>>
> >
> > >> I am not clear about the method. The board files export the
> > >> omap_mmc_platform_data.
> > >> Does it imply that all board files have to change and export
> > >> the capability so that it can be queried ?
> > > No. You don't have to modify the board files. This would need
> > > change in devices.c which common for all omap boards.
> > >
> > > I don't have a strong opinion on this point but just put forth an
> > > alternate way to avoid such SOC specific check in drivers.
> > > You can take call on this
> >
> > Agree. How about adding a flag in hsmmc.h & omap_mmc_platform_data,
> > that would take care of SDMA & SDMA_DLAOD in the driver instead going
> > with SOC check .
>
> Good idea Kishore.
> Venkat,
> Can you do what kishore is suggesting.
>
omap_mmc_platform_data is MMC specific platform data. Why add a SDMA
specific feature capability into it? Even though you add it there, you will
still need to have a cpu check before that can be set in a common code.

> Regards,
> Santosh