linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@nokia.com>
To: Sukumar Ghorai <s-ghorai@ti.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Madhusudhan Chikkature <madhu.cr@ti.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] omap: hsmmc funtionality breaks when CONFIG_PM not define
Date: Tue, 20 Jul 2010 10:09:13 +0300	[thread overview]
Message-ID: <4C454B99.7090705@nokia.com> (raw)
In-Reply-To: <1279607878-2405-1-git-send-email-s-ghorai@ti.com>

Sukumar Ghorai wrote:
>     Issue if power_saving option passed from board file and CONFIG_PM not define.
>     This is because hosts refer to wrong operation table and that try to power save.

power_saving is not related to power management.  It should work with or without
CONFIG_PM.  What problem are you seeing?

> 
> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> CC: Madhusudhan Chikkature <madhu.cr@ti.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> ---
>  Tested on omap3, omap4430 ES2.0
> 
>  drivers/mmc/host/omap_hsmmc.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index b032828..f84eed0 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2015,9 +2015,11 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, host);
>  	INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect);
>  
> +#ifdef CONFIG_PM
>  	if (mmc_slot(host).power_saving)
>  		mmc->ops	= &omap_hsmmc_ps_ops;
>  	else
> +#endif
>  		mmc->ops	= &omap_hsmmc_ops;
>  
>  	/*
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


  reply	other threads:[~2010-07-20  7:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-20  6:37 [PATCH] omap: hsmmc funtionality breaks when CONFIG_PM not define Sukumar Ghorai
2010-07-20  7:09 ` Adrian Hunter [this message]
2010-07-20  7:51   ` Ghorai, Sukumar
2010-07-20  8:10     ` Adrian Hunter
2010-07-20  8:17       ` Ghorai, Sukumar
2010-07-20  8:40         ` Adrian Hunter
2010-07-20  8:48           ` Ghorai, Sukumar
2010-07-20  9:13             ` Adrian Hunter
2010-07-20 13:21               ` Ghorai, Sukumar
2010-07-21  6:16                 ` Adrian Hunter
2010-07-21  6:33                   ` Ghorai, Sukumar
2010-07-20 14:06               ` kishore kadiyala
2010-07-21  6:33                 ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C454B99.7090705@nokia.com \
    --to=adrian.hunter@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=madhu.cr@ti.com \
    --cc=s-ghorai@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).