From: Adrian Hunter <adrian.hunter@nokia.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>
Subject: Re: [PATCH] Fix mmc_test build order
Date: Mon, 26 Jul 2010 14:05:29 +0300 [thread overview]
Message-ID: <4C4D6BF9.1040704@nokia.com> (raw)
In-Reply-To: <20100726100956.GA17996@july>
Kyungmin Park wrote:
> To use the mmc_test, it should be build before mmc_block.
>
> Reported-by: Adrian Hunter <adrian.hunter@nokia.com>
I did not report this. I just pointed out that mmc_test
will not work if mmc_block has already been given all the
MMC devices.
You can always switch between mmc_test and mmc_block by
unbinding / binding e.g.
# ls -al /sys/bus/mmc/drivers/mmcblk
drwxr-xr-x 2 root 0 0 Jan 1 00:00 .
drwxr-xr-x 4 root 0 0 Jan 1 00:00 ..
--w------- 1 root 0 4096 Jan 1 00:01 bind
lrwxrwxrwx 1 root 0 0 Jan 1 00:01 mmc0:0001 -> ../../../../devices/platform/mmci-omap-hs.1/mmc_host/mmc0/mmc0:0001
--w------- 1 root 0 4096 Jan 1 00:01 uevent
--w------- 1 root 0 4096 Jan 1 00:01 unbind
# echo mmc0:0001 > /sys/bus/mmc/drivers/mmcblk/unbind
# echo mmc0:0001 > /sys/bus/mmc/drivers/mmc_test/bind
[ 128.221313] mmc_test mmc0:0001: Card claimed for testing.
I suggest adding explanation to the Kconfig help text for
MMC_TEST and also the module decription in drivers/mmc/card/mmc_test.c
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/drivers/mmc/card/Makefile b/drivers/mmc/card/Makefile
> index 0d40751..9d50437 100644
> --- a/drivers/mmc/card/Makefile
> +++ b/drivers/mmc/card/Makefile
> @@ -6,9 +6,9 @@ ifeq ($(CONFIG_MMC_DEBUG),y)
> EXTRA_CFLAGS += -DDEBUG
> endif
>
> +obj-$(CONFIG_MMC_TEST) += mmc_test.o
> obj-$(CONFIG_MMC_BLOCK) += mmc_block.o
> mmc_block-objs := block.o queue.o
> -obj-$(CONFIG_MMC_TEST) += mmc_test.o
>
> obj-$(CONFIG_SDIO_UART) += sdio_uart.o
>
>
next prev parent reply other threads:[~2010-07-26 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 10:09 [PATCH] Fix mmc_test build order Kyungmin Park
2010-07-26 11:05 ` Adrian Hunter [this message]
2010-07-26 12:27 ` [PATCH] mmc: add device class attribute for ext_csd Ghorai, Sukumar
2010-07-26 12:42 ` Adrian Hunter
2010-07-26 15:00 ` Ghorai, Sukumar
2010-07-27 7:51 ` Adrian Hunter
2010-07-27 10:50 ` Ghorai, Sukumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4D6BF9.1040704@nokia.com \
--to=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=kmpark@infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).